Skip to content

Incremental builds often fail to update the version number #4173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rtoy opened this issue Jul 10, 2024 · 4 comments
Open

Incremental builds often fail to update the version number #4173

rtoy opened this issue Jul 10, 2024 · 4 comments

Comments

@rtoy
Copy link
Owner

rtoy commented Jul 10, 2024

Imported from SourceForge on 2024-07-09 19:32:11
Created by peterpall on 2021-05-21 05:56:33
Original: https://sourceforge.net/p/maxima/bugs/3783


If only a few lines of code have changed chances are high that the version number maxima believes to have isn't updated according to "git describe". This means that for compiled share packages the old folder is recycled which can lead to odd results.

For the defsystem wizards: Do we need to introduce a new defsystem package that contains the version number and is always built?

@rtoy
Copy link
Owner Author

rtoy commented Jul 10, 2024

Imported from SourceForge on 2024-07-09 19:32:12
Created by robert_dodier on 2021-05-23 18:43:04
Original: https://sourceforge.net/p/maxima/bugs/3783/#dc69


  • labels: --> build, version

@rtoy
Copy link
Owner Author

rtoy commented Jul 10, 2024

Imported from SourceForge on 2024-07-09 19:32:16
Created by robert_dodier on 2021-05-23 18:43:04
Original: https://sourceforge.net/p/maxima/bugs/3783/#5b8c


Well, git describe is executed by configure. I don't think the output of git describe depends on how many lines were changed, but rather on what the current commit is -- if there is a new commit, then git describe has a different output.

Did you execute configure? That should ensure that Maxima has a different version when there are new commits.

@rtoy
Copy link
Owner Author

rtoy commented Jul 10, 2024

Imported from SourceForge on 2024-07-09 19:32:19
Created by robert_dodier on 2021-06-20 21:06:24
Original: https://sourceforge.net/p/maxima/bugs/3783/#812a


  • status: open --> wont-fix

@rtoy
Copy link
Owner Author

rtoy commented Jul 10, 2024

Imported from SourceForge on 2024-07-09 19:32:22
Created by robert_dodier on 2021-06-20 21:06:25
Original: https://sourceforge.net/p/maxima/bugs/3783/#c3f8


Although I see the problem with the version number not being updated automatically every time make is executed, there is a simple workaround, and since it is not a user-visible issue, there is not much incentive to change it. Also, the build machinery is delicate and complex and it would be easy to accidentally introduce another problem by trying to resolve this one. That said, if someone has a specific proposal to implement this feature, I would be interested to take a look at it. Until then I'm going to mark this item as won't fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant