From f6bdf7b3d9288fa85e37c591cba06095ee9ebd7a Mon Sep 17 00:00:00 2001 From: Justin Marsh Date: Sat, 24 May 2025 19:07:43 +0200 Subject: [PATCH 1/2] Fix error in dialog_controller.js by checking for event before calling preventDefault --- lib/ruby_ui/dialog/dialog_controller.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/ruby_ui/dialog/dialog_controller.js b/lib/ruby_ui/dialog/dialog_controller.js index 03692435..fff5a63b 100644 --- a/lib/ruby_ui/dialog/dialog_controller.js +++ b/lib/ruby_ui/dialog/dialog_controller.js @@ -17,7 +17,9 @@ export default class extends Controller { } open(e) { - e.preventDefault() + if (e) { + e.preventDefault(); + } document.body.insertAdjacentHTML('beforeend', this.contentTarget.innerHTML) // prevent scroll on body document.body.classList.add('overflow-hidden') From aaf0a58d3d1a08de7606fc8c9bbeaeba6a98fbed Mon Sep 17 00:00:00 2001 From: Justin Marsh Date: Sat, 24 May 2025 19:24:53 +0200 Subject: [PATCH 2/2] use save calling syntax --- lib/ruby_ui/dialog/dialog_controller.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/ruby_ui/dialog/dialog_controller.js b/lib/ruby_ui/dialog/dialog_controller.js index fff5a63b..26bf1fa0 100644 --- a/lib/ruby_ui/dialog/dialog_controller.js +++ b/lib/ruby_ui/dialog/dialog_controller.js @@ -17,9 +17,7 @@ export default class extends Controller { } open(e) { - if (e) { - e.preventDefault(); - } + e?.preventDefault(); document.body.insertAdjacentHTML('beforeend', this.contentTarget.innerHTML) // prevent scroll on body document.body.classList.add('overflow-hidden')