Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release target tags and releases but CI also releases from tag #712

Open
headius opened this issue Jan 28, 2025 · 1 comment
Open

Release target tags and releases but CI also releases from tag #712

headius opened this issue Jan 28, 2025 · 1 comment

Comments

@headius
Copy link
Contributor

headius commented Jan 28, 2025

I recently pushed new Psych gems and ran into confusion with the documented release instructions and the way things happen in reality.

The documentation says to use rake release to release the gem, which will tag the version, push the tag, and then build and push the gems.

However CI is also set up to automatically push release gems when the tag is pushed. This led to my local pushes conflicting with the CI pushes and that confusion led me to file rubygems/rubygems#8420.

I think we need to decide on one way or the other: either release in CI from the tag, or release from local environment after pushing the tag.

@hsbt
Copy link
Member

hsbt commented Jan 30, 2025

After b9226fc, we could release a newer gem with git tag vXXX && git push --tags simply.

The workflow of trusted publisher will create and push Ruby and JRuby artifacts automatically. I sometimes forgot to push JRuby version of psych. The trusted publisher helps that my mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants