Skip to content

metadata.owner field in Ruby package.yml files not being respected #141

@joshuaylee

Description

@joshuaylee

Summary

The code_ownership documentation states that Ruby packages support ownership via both:

  1. Top-level owner field
  2. Nested metadata.owner field

However, the codeowner-rs documentation only mentions the top-level owner field. The code suggests metadata.owner is not currently supported for Ruby packages (though it is supported for JavaScript packages).

Expected Behavior

Ruby package.yml files should support ownership in either format:

  # Format 1: top-level owner
  owner: TeamName

  # Format 2: nested metadata.owner
  metadata:
    owner: TeamName

Current Behavior

Only Format 1 is supported (with code_ownership 2.0.0 and RustCodeOwners.version returning 0.3.0)

Questions

  1. Is the code_ownership documentation correct? Should codeowners-rs support metadata.owner for Ruby packages, to support the previous behavior of code_ownership?
  2. If yes, how should it handle conflicts when both fields are present (e.g., precedence rules or validation warnings)?
  3. If no, should the code_ownership docs be updated to remove mention of metadata.owner support?

I'd be happy to submit a PR in codeowner-rs or code_ownership depending on the direction.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingdocumentationImprovements or additions to documentation

    Type

    No type

    Projects

    Status

    Triage

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions