-
Notifications
You must be signed in to change notification settings - Fork 26
Open
Labels
bugSomething isn't workingSomething isn't workingdocumentationImprovements or additions to documentationImprovements or additions to documentation
Description
Summary
The code_ownership documentation states that Ruby packages support ownership via both:
- Top-level owner field
- Nested metadata.owner field
However, the codeowner-rs documentation only mentions the top-level owner field. The code suggests metadata.owner is not currently supported for Ruby packages (though it is supported for JavaScript packages).
Expected Behavior
Ruby package.yml files should support ownership in either format:
# Format 1: top-level owner
owner: TeamName
# Format 2: nested metadata.owner
metadata:
owner: TeamName
Current Behavior
Only Format 1 is supported (with code_ownership 2.0.0 and RustCodeOwners.version returning 0.3.0)
Questions
- Is the code_ownership documentation correct? Should codeowners-rs support metadata.owner for Ruby packages, to support the previous behavior of code_ownership?
- If yes, how should it handle conflicts when both fields are present (e.g., precedence rules or validation warnings)?
- If no, should the code_ownership docs be updated to remove mention of metadata.owner support?
I'd be happy to submit a PR in codeowner-rs or code_ownership depending on the direction.
tylerwillingham
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingdocumentationImprovements or additions to documentationImprovements or additions to documentation
Type
Projects
Status
Triage