Skip to content

Restoring /var/lib/docker with a service doesn't restart the service #18

Description

@JulesClaussen

Hello,

I noticed a small bug when using services, and snapshot restoration. Below a small reproduction:

jobs:
  restore-db:
    name: restore-db
    runs-on: runs-on=${{ github.run_id }}-db-checks/runner=2cpu-linux-x64/extras=s3-cache
    timeout-minutes: 30

    env:
      POSTGRES_USER: user
      POSTGRES_PASSWORD: password
      POSTGRES_DB: database

    services:
      postgres:
        image: postgres:${{ inputs.pgDockerTag }}
        options: >-
          --health-cmd pg_isready
          --health-interval 10s
          --health-timeout 5s
          --health-retries 5
        ports:
          - '5432'
        env:
          POSTGRES_USER: ${{ env.POSTGRES_USER }}
          POSTGRES_PASSWORD: ${{ env.POSTGRES_PASSWORD }}
          POSTGRES_DB: ${{ env.POSTGRES_DB }}

    steps:
      - name: Checkout
        uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0

      - uses: runs-on/action@v2

      - uses: runs-on/snapshot@feature/restore-only
        with:
          path: /var/lib/docker
          save: false

When the snapshot is restored, the service postgres is not restarted.
Not sure how to solve this, you either want to take note of running container and restart them, or restore before, but not sure if you can run steps before Github own ones

Thank you!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions