Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't reinstall buddy package if it is present #8

Closed
russHyde opened this issue Jan 10, 2019 · 0 comments
Closed

Don't reinstall buddy package if it is present #8

russHyde opened this issue Jan 10, 2019 · 0 comments
Labels
01 : feature New feature or request

Comments

@russHyde
Copy link
Owner

russHyde commented Jan 10, 2019

Currently, setup.sh installs buddy package using pip. But it does this every time that ./setup.sh is called.

Would prefer if

  • buddy was installed at the first run of ./scripts.setup.sh

  • and then installed again only if the version installed in the current environment predates the source code in ./scripts/helpers_for_setup/buddy

For the latter, see #20

@russHyde russHyde added the 01 : feature New feature or request label Jan 18, 2019
@russHyde russHyde changed the title only install buddy package if it is absent or modified Don't reinstall buddy package if it is present Jan 18, 2019
russHyde added a commit that referenced this issue Jan 18, 2019
When buddy has already been installed into the current environment, it should
not be reinstalled.

- The user should `pip uninstall` if they want to update the `buddy` package.

Also allow undefined variables in `check_env.sh`:

- By dropping `set -u` in `check_env.sh` we can use informative messages when
`CONDA_PREFIX` is not defined and urge the user to activate the relevant
environment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
01 : feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant