Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing Tests #2

Open
russkel opened this issue Nov 21, 2020 · 3 comments
Open

Failing Tests #2

russkel opened this issue Nov 21, 2020 · 3 comments

Comments

@russkel
Copy link
Owner

russkel commented Nov 21, 2020

https://travis-ci.com/github/russkel/python-moos/jobs/445116321#L1644

MOOSCommObject::SendPkt Exception caught Error sending socket message: Bad file descriptor

1605930046.2350   AsynchronousWriteLoop() catches exception and exits

----
======================================================================

FAIL: test_20_zmsg_types (__main__.pyMOOSTestCase)Exception in DoReading() : remote side closed....

----------------------------------------------------------------------

Traceback (most recent call last):

  File "tests/test.py", line 164, in test_20_zmsg_types

    self.assertTrue(c.is_registered_for('TEST_STRING_VAR'))

AssertionError: False is not true

======================================================================

FAIL: test_33_on_mail_active_queues (__main__.pyMOOSTestCase)

----------------------------------------------------------------------

Traceback (most recent call last):

  File "tests/test.py", line 352, in test_33_on_mail_active_queues

    self.assertTrue(self.received_mail_q_v1)

AssertionError: False is not true

----------------------------------------------------------------------

Ran 11 tests in 13.043s

FAILED (failures=2)

1605930054.5393 139795917420288-                           disabling nagle

-------------- moos connect ----------------------

  contacting a MOOS server localhost:9000 -  try 00001 

  Handshaking as test_on_mail_active_queuesException in DoReading() : remote side closed....

1605930054.5397 139796192098048-                           disabling nagle

-------------- moos connect ----------------------

  contacting a MOOS server localhost:9000 -  try 00001 

  Handshaking as test_zmsg_types        Exception in hand shaking : remote side closed....--------------------------------------------------

Exception in hand shaking : remote side closed....--------------------------------------------------


@russkel
Copy link
Owner Author

russkel commented Nov 21, 2020

https://travis-ci.com/github/russkel/python-moos/jobs/445116322

======================================================================

FAIL: test_33_on_mail_active_queues (__main__.pyMOOSTestCase)

----------------------------------------------------------------------

Traceback (most recent call last):

  File "tests/test.py", line 352, in test_33_on_mail_active_queues

    self.assertTrue(self.received_mail_q_v1)

AssertionError: False is not true

@oviquezr
Copy link
Collaborator

oviquezr commented Feb 4, 2021

I think there is something else wrong here. The MacOS test failed for no reason on a CI run which passed after I reran it.

Agreed that there is something odd – I merged the BASE: fix after rebasing and verifying the tests passed, and now they are failing when CI runs under master. Have rerun it 3 times now and I haven't been able to make sense of the failure yet. In one of the runs, it seemed like the subprocess that handled the MOOSDB simply quit, but it hasn't been consistent

@russkel
Copy link
Owner Author

russkel commented Feb 4, 2021

And before that the Release action didn't complete either: https://github.com/russkel/python-moos/actions/runs/536292725

Okay so we need more visibility into why the subprocess is terminating.

In the meantime I am rerunning the release job. If this actually works then maybe we disable tests for wheel builds, but leave it on for Pip builds until we can get tests reliable in Pip builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants