Merge #148: Implement savemempool method and test

565702f Implement savemempool method and test (GideonBature)

Pull request description:

  Going by the conversations with tcharding  for PR #116 on implementing one method at a time for easier review: This is the second method implementation `savemempool` which is a specific type that returns a (json null). Once this is approved, I’ll proceed with the next one.

ACKs for top commit:
  tcharding:
    ACK 565702f

Tree-SHA512: 85d0d2ef8fa48cc325efc4f7eb9dfbf1276fe9185ff0c3bc2639aaec924088795638b82fb51856cd8454d24a7c59332297921ee00db38efb7e02db35bddbc1fc

Author: tcharding

client/src/client_sync/v17/blockchain.rs

@@ -302,6 +302,22 @@ macro_rules! impl_client_v17__pruneblockchain {
     };
 }
 
+/// Implements Bitcoin Core JSON-RPC API method `savemempool`
+#[macro_export]
+macro_rules! impl_client_v17__savemempool {
+    () => {
+        impl Client {
+            pub fn save_mempool(&self) -> Result<()> {
+                match self.call("savemempool", &[]) {
+                    Ok(serde_json::Value::Null) => Ok(()),
+                    Ok(res) => Err(Error::Returned(res.to_string())),
+                    Err(err) => Err(err.into()),
+                }
+            }
+        }
+    };
+}
+
 /// Implements Bitcoin Core JSON-RPC API method `verifytxoutproof`
 #[macro_export]
 macro_rules! impl_client_v17__verifytxoutproof {

client/src/client_sync/v17/mod.rs

@@ -49,6 +49,7 @@ crate::impl_client_v17__gettxoutproof!();
 crate::impl_client_v17__gettxoutsetinfo!();
 crate::impl_client_v17__preciousblock!();
 crate::impl_client_v17__pruneblockchain!();
+crate::impl_client_v17__savemempool!();
 crate::impl_client_v17__verifytxoutproof!();
 
 // == Control ==

client/src/client_sync/v18/mod.rs

@@ -43,6 +43,7 @@ crate::impl_client_v17__gettxoutproof!();
 crate::impl_client_v17__gettxoutsetinfo!();
 crate::impl_client_v17__preciousblock!();
 crate::impl_client_v17__pruneblockchain!();
+crate::impl_client_v17__savemempool!();
 crate::impl_client_v17__verifytxoutproof!();
 
 // == Control ==

client/src/client_sync/v19/mod.rs

@@ -44,6 +44,7 @@ crate::impl_client_v17__gettxoutproof!();
 crate::impl_client_v17__gettxoutsetinfo!();
 crate::impl_client_v17__preciousblock!();
 crate::impl_client_v17__pruneblockchain!();
+crate::impl_client_v17__savemempool!();
 crate::impl_client_v17__verifytxoutproof!();
 
 // == Control ==

client/src/client_sync/v20.rs

@@ -41,6 +41,7 @@ crate::impl_client_v17__gettxoutproof!();
 crate::impl_client_v17__gettxoutsetinfo!();
 crate::impl_client_v17__preciousblock!();
 crate::impl_client_v17__pruneblockchain!();
+crate::impl_client_v17__savemempool!();
 crate::impl_client_v17__verifytxoutproof!();
 
 // == Control ==

client/src/client_sync/v21/mod.rs

@@ -43,6 +43,7 @@ crate::impl_client_v17__gettxoutproof!();
 crate::impl_client_v17__gettxoutsetinfo!();
 crate::impl_client_v17__preciousblock!();
 crate::impl_client_v17__pruneblockchain!();
+crate::impl_client_v17__savemempool!();
 crate::impl_client_v17__verifytxoutproof!();
 
 // == Control ==

client/src/client_sync/v22/mod.rs

@@ -44,6 +44,7 @@ crate::impl_client_v17__gettxoutproof!();
 crate::impl_client_v17__gettxoutsetinfo!();
 crate::impl_client_v17__preciousblock!();
 crate::impl_client_v17__pruneblockchain!();
+crate::impl_client_v17__savemempool!();
 crate::impl_client_v17__verifytxoutproof!();
 
 // == Control ==

client/src/client_sync/v23/blockchain.rs

@@ -0,0 +1,19 @@
+// SPDX-License-Identifier: CC0-1.0
+
+//! Macros for implementing JSON-RPC methods on a client.
+//!
+//! Specifically this is methods found under the `== Blockchain ==` section of the
+//! API docs of Bitcoin Core `v0.23`.
+//!
+//! All macros require `Client` to be in scope.
+//!
+//! See or use the `define_jsonrpc_minreq_client!` macro to define a `Client`.
+/// Implements Bitcoin Core JSON-RPC API method `savemempool`
+#[macro_export]
+macro_rules! impl_client_v23__savemempool {
+    () => {
+        impl Client {
+            pub fn save_mempool(&self) -> Result<SaveMempool> { self.call("savemempool", &[]) }
+        }
+    };
+}

client/src/client_sync/v23/mod.rs

@@ -4,6 +4,7 @@
 //!
 //! We ignore option arguments unless they effect the shape of the returned JSON data.
 
+pub mod blockchain;
 pub mod wallet;
 
 use std::collections::BTreeMap;
@@ -44,6 +45,7 @@ crate::impl_client_v17__gettxoutproof!();
 crate::impl_client_v17__gettxoutsetinfo!();
 crate::impl_client_v17__preciousblock!();
 crate::impl_client_v17__pruneblockchain!();
+crate::impl_client_v23__savemempool!();
 crate::impl_client_v17__verifytxoutproof!();
 
 // == Control ==

client/src/client_sync/v24.rs

@@ -41,6 +41,7 @@ crate::impl_client_v17__gettxoutproof!();
 crate::impl_client_v17__gettxoutsetinfo!();
 crate::impl_client_v17__preciousblock!();
 crate::impl_client_v17__pruneblockchain!();
+crate::impl_client_v23__savemempool!();
 crate::impl_client_v17__verifytxoutproof!();
 
 // == Control ==