Implement verifychain method and test

Author: GideonBature

client/src/client_sync/v17/blockchain.rs

@@ -318,6 +318,16 @@ macro_rules! impl_client_v17__savemempool {
     };
 }
 
+/// Implements Bitcoin Core JSON-RPC API method `verifychain`
+#[macro_export]
+macro_rules! impl_client_v17__verifychain {
+    () => {
+        impl Client {
+            pub fn verify_chain(&self) -> Result<VerifyChain> { self.call("verifychain", &[]) }
+        }
+    };
+}
+
 /// Implements Bitcoin Core JSON-RPC API method `verifytxoutproof`
 #[macro_export]
 macro_rules! impl_client_v17__verifytxoutproof {

client/src/client_sync/v17/mod.rs

@@ -50,6 +50,7 @@ crate::impl_client_v17__gettxoutsetinfo!();
 crate::impl_client_v17__preciousblock!();
 crate::impl_client_v17__pruneblockchain!();
 crate::impl_client_v17__savemempool!();
+crate::impl_client_v17__verifychain!();
 crate::impl_client_v17__verifytxoutproof!();
 
 // == Control ==

client/src/client_sync/v18/mod.rs

@@ -44,6 +44,7 @@ crate::impl_client_v17__gettxoutsetinfo!();
 crate::impl_client_v17__preciousblock!();
 crate::impl_client_v17__pruneblockchain!();
 crate::impl_client_v17__savemempool!();
+crate::impl_client_v17__verifychain!();
 crate::impl_client_v17__verifytxoutproof!();
 
 // == Control ==

client/src/client_sync/v19/mod.rs

@@ -45,6 +45,7 @@ crate::impl_client_v17__gettxoutsetinfo!();
 crate::impl_client_v17__preciousblock!();
 crate::impl_client_v17__pruneblockchain!();
 crate::impl_client_v17__savemempool!();
+crate::impl_client_v17__verifychain!();
 crate::impl_client_v17__verifytxoutproof!();
 
 // == Control ==

client/src/client_sync/v20.rs

@@ -42,6 +42,7 @@ crate::impl_client_v17__gettxoutsetinfo!();
 crate::impl_client_v17__preciousblock!();
 crate::impl_client_v17__pruneblockchain!();
 crate::impl_client_v17__savemempool!();
+crate::impl_client_v17__verifychain!();
 crate::impl_client_v17__verifytxoutproof!();
 
 // == Control ==

client/src/client_sync/v21/mod.rs

@@ -44,6 +44,7 @@ crate::impl_client_v17__gettxoutsetinfo!();
 crate::impl_client_v17__preciousblock!();
 crate::impl_client_v17__pruneblockchain!();
 crate::impl_client_v17__savemempool!();
+crate::impl_client_v17__verifychain!();
 crate::impl_client_v17__verifytxoutproof!();
 
 // == Control ==

client/src/client_sync/v22/mod.rs

@@ -45,6 +45,7 @@ crate::impl_client_v17__gettxoutsetinfo!();
 crate::impl_client_v17__preciousblock!();
 crate::impl_client_v17__pruneblockchain!();
 crate::impl_client_v17__savemempool!();
+crate::impl_client_v17__verifychain!();
 crate::impl_client_v17__verifytxoutproof!();
 
 // == Control ==

client/src/client_sync/v23/mod.rs

@@ -46,6 +46,7 @@ crate::impl_client_v17__gettxoutsetinfo!();
 crate::impl_client_v17__preciousblock!();
 crate::impl_client_v17__pruneblockchain!();
 crate::impl_client_v23__savemempool!();
+crate::impl_client_v17__verifychain!();
 crate::impl_client_v17__verifytxoutproof!();
 
 // == Control ==

client/src/client_sync/v24.rs

@@ -42,6 +42,7 @@ crate::impl_client_v17__gettxoutsetinfo!();
 crate::impl_client_v17__preciousblock!();
 crate::impl_client_v17__pruneblockchain!();
 crate::impl_client_v23__savemempool!();
+crate::impl_client_v17__verifychain!();
 crate::impl_client_v17__verifytxoutproof!();
 
 // == Control ==

client/src/client_sync/v25.rs

@@ -42,6 +42,7 @@ crate::impl_client_v17__gettxoutsetinfo!();
 crate::impl_client_v17__preciousblock!();
 crate::impl_client_v17__pruneblockchain!();
 crate::impl_client_v23__savemempool!();
+crate::impl_client_v17__verifychain!();
 crate::impl_client_v17__verifytxoutproof!();
 
 // == Control ==

client/src/client_sync/v26/mod.rs

@@ -46,6 +46,7 @@ crate::impl_client_v26__gettxoutsetinfo!();
 crate::impl_client_v17__preciousblock!();
 crate::impl_client_v17__pruneblockchain!();
 crate::impl_client_v23__savemempool!();
+crate::impl_client_v17__verifychain!();
 crate::impl_client_v17__verifytxoutproof!();
 
 // == Control ==

client/src/client_sync/v27.rs

@@ -42,6 +42,7 @@ crate::impl_client_v26__gettxoutsetinfo!();
 crate::impl_client_v17__preciousblock!();
 crate::impl_client_v17__pruneblockchain!();
 crate::impl_client_v23__savemempool!();
+crate::impl_client_v17__verifychain!();
 crate::impl_client_v17__verifytxoutproof!();
 
 // == Control ==

client/src/client_sync/v28/mod.rs

@@ -44,6 +44,7 @@ crate::impl_client_v26__gettxoutsetinfo!();
 crate::impl_client_v17__preciousblock!();
 crate::impl_client_v17__pruneblockchain!();
 crate::impl_client_v23__savemempool!();
+crate::impl_client_v17__verifychain!();
 crate::impl_client_v17__verifytxoutproof!();
 
 // == Control ==

integration_test/tests/blockchain.rs

@@ -321,6 +321,13 @@ fn blockchain__get_tx_out_proof__modelled() {
     verify_tx_out_proof(&node).unwrap();
 }
 
+#[test]
+fn blockchain__verify_chain() {
+    let node = Node::with_wallet(Wallet::None, &[]);
+
+    let _: Result<VerifyChain, _> = node.client.verify_chain();
+}
+
 fn verify_tx_out_proof(node: &Node) -> Result<(), client_sync::Error> {
     let (_address, tx) = node.create_mined_transaction();
     let txid = tx.compute_txid();

types/src/v17/blockchain/mod.rs

@@ -650,6 +650,10 @@ pub struct PruneBlockchain(
     pub i64,
 );
 
+/// Result of JSON-RPC method `verifychain`.
+#[derive(Clone, Debug, PartialEq, Deserialize, Serialize)]
+pub struct VerifyChain(pub bool);
+
 /// Result of JSON-RPC method `verifytxoutproof`.
 ///
 /// > verifytxoutproof "proof"

types/src/v17/mod.rs

@@ -244,7 +244,7 @@ pub use self::{
         GetRawMempool, GetRawMempoolVerbose, GetTxOut, GetTxOutError, GetTxOutSetInfo,
         GetTxOutSetInfoError, MapMempoolEntryError, MempoolEntry, MempoolEntryError,
         MempoolEntryFees, MempoolEntryFeesError, PruneBlockchain, Softfork, SoftforkReject,
-        VerifyTxOutProof,
+        VerifyChain, VerifyTxOutProof,
     },
     control::{GetMemoryInfoStats, Locked, Logging},
     generating::{Generate, GenerateToAddress},

types/src/v18/mod.rs

@@ -267,6 +267,6 @@ pub use crate::v17::{
     RawTransaction, RawTransactionError, RawTransactionInput, RawTransactionOutput,
     RescanBlockchain, SendMany, SendRawTransaction, SendToAddress, SignFail, SignFailError,
     SignMessage, SignRawTransaction, SignRawTransactionError, Softfork, SoftforkReject,
-    TestMempoolAccept, TransactionCategory, UploadTarget, VerifyTxOutProof, WalletCreateFundedPsbt,
-    WalletCreateFundedPsbtError, WalletProcessPsbt, WitnessUtxo,
+    TestMempoolAccept, TransactionCategory, UploadTarget, VerifyChain, VerifyTxOutProof,
+    WalletCreateFundedPsbt, WalletCreateFundedPsbtError, WalletProcessPsbt, WitnessUtxo,
 };

types/src/v19/mod.rs

@@ -268,8 +268,8 @@ pub use crate::v17::{
     PruneBlockchain, RawTransactionError, RawTransactionInput, RawTransactionOutput,
     RescanBlockchain, SendMany, SendRawTransaction, SendToAddress, SignMessage, SignRawTransaction,
     SignRawTransactionError, SoftforkReject, TestMempoolAccept, TransactionCategory, UploadTarget,
-    VerifyTxOutProof, WalletCreateFundedPsbt, WalletCreateFundedPsbtError, WalletProcessPsbt,
-    WitnessUtxo,
+    VerifyChain, VerifyTxOutProof, WalletCreateFundedPsbt, WalletCreateFundedPsbtError,
+    WalletProcessPsbt, WitnessUtxo,
 };
 #[doc(inline)]
 pub use crate::v18::{

types/src/v20/mod.rs

@@ -261,8 +261,8 @@ pub use crate::{
         RawTransactionError, RawTransactionInput, RawTransactionOutput, RescanBlockchain, SendMany,
         SendRawTransaction, SendToAddress, SignMessage, SignRawTransaction,
         SignRawTransactionError, SoftforkReject, TestMempoolAccept, TransactionCategory,
-        UploadTarget, VerifyTxOutProof, WalletCreateFundedPsbt, WalletCreateFundedPsbtError,
-        WalletProcessPsbt, WitnessUtxo,
+        UploadTarget, VerifyChain, VerifyTxOutProof, WalletCreateFundedPsbt,
+        WalletCreateFundedPsbtError, WalletProcessPsbt, WitnessUtxo,
     },
     v18::{
         ActiveCommand, AnalyzePsbt, AnalyzePsbtError, AnalyzePsbtInput, AnalyzePsbtInputMissing,

types/src/v21/mod.rs

@@ -267,8 +267,8 @@ pub use crate::{
         RawTransactionError, RawTransactionInput, RawTransactionOutput, RescanBlockchain, SendMany,
         SendRawTransaction, SendToAddress, SignMessage, SignRawTransaction,
         SignRawTransactionError, SoftforkReject, TestMempoolAccept, TransactionCategory,
-        UploadTarget, VerifyTxOutProof, WalletCreateFundedPsbt, WalletCreateFundedPsbtError,
-        WalletProcessPsbt, WitnessUtxo,
+        UploadTarget, VerifyChain, VerifyTxOutProof, WalletCreateFundedPsbt,
+        WalletCreateFundedPsbtError, WalletProcessPsbt, WitnessUtxo,
     },
     v18::{
         ActiveCommand, AnalyzePsbt, AnalyzePsbtError, AnalyzePsbtInput, AnalyzePsbtInputMissing,

types/src/v22/mod.rs

@@ -281,7 +281,7 @@ pub use crate::{
         LoadWallet, Locked, PeerInfo, PruneBlockchain, RawTransactionError, RawTransactionInput,
         RawTransactionOutput, RescanBlockchain, SendMany, SendRawTransaction, SendToAddress,
         SignMessage, SignRawTransaction, SignRawTransactionError, SoftforkReject,
-        TestMempoolAccept, TransactionCategory, UploadTarget, VerifyTxOutProof,
+        TestMempoolAccept, TransactionCategory, UploadTarget, VerifyChain, VerifyTxOutProof,
         WalletCreateFundedPsbt, WalletCreateFundedPsbtError, WalletProcessPsbt, WitnessUtxo,
     },
     v18::{

types/src/v23/mod.rs

@@ -276,7 +276,7 @@ pub use crate::{
         LoadWallet, Locked, PeerInfo, PruneBlockchain, RawTransactionError, RawTransactionInput,
         RawTransactionOutput, RescanBlockchain, SendMany, SendRawTransaction, SendToAddress,
         SignMessage, SignRawTransaction, SignRawTransactionError, SoftforkReject,
-        TestMempoolAccept, TransactionCategory, UploadTarget, VerifyTxOutProof,
+        TestMempoolAccept, TransactionCategory, UploadTarget, VerifyChain, VerifyTxOutProof,
         WalletCreateFundedPsbt, WalletCreateFundedPsbtError, WalletProcessPsbt, WitnessUtxo,
     },
     v18::{

types/src/v24/mod.rs

@@ -277,7 +277,7 @@ pub use crate::{
         LoadWallet, Locked, PeerInfo, PruneBlockchain, RawTransactionError, RawTransactionInput,
         RawTransactionOutput, RescanBlockchain, SendMany, SendRawTransaction, SendToAddress,
         SignMessage, SignRawTransaction, SignRawTransactionError, SoftforkReject,
-        TestMempoolAccept, TransactionCategory, UploadTarget, VerifyTxOutProof,
+        TestMempoolAccept, TransactionCategory, UploadTarget, VerifyChain, VerifyTxOutProof,
         WalletCreateFundedPsbt, WalletCreateFundedPsbtError, WalletProcessPsbt, WitnessUtxo,
     },
     v18::{

types/src/v25/mod.rs

@@ -274,7 +274,7 @@ pub use crate::{
         Locked, PeerInfo, PruneBlockchain, RawTransactionError, RawTransactionInput,
         RawTransactionOutput, RescanBlockchain, SendMany, SendRawTransaction, SendToAddress,
         SignMessage, SignRawTransaction, SignRawTransactionError, SoftforkReject,
-        TestMempoolAccept, TransactionCategory, UploadTarget, VerifyTxOutProof,
+        TestMempoolAccept, TransactionCategory, UploadTarget, VerifyChain, VerifyTxOutProof,
         WalletCreateFundedPsbt, WalletCreateFundedPsbtError, WalletProcessPsbt, WitnessUtxo,
     },
     v18::{

types/src/v26/mod.rs

@@ -294,7 +294,7 @@ pub use crate::{
         Locked, PeerInfo, PruneBlockchain, RawTransactionError, RawTransactionInput,
         RawTransactionOutput, RescanBlockchain, SendMany, SendRawTransaction, SendToAddress,
         SignMessage, SignRawTransaction, SignRawTransactionError, SoftforkReject,
-        TestMempoolAccept, TransactionCategory, UploadTarget, VerifyTxOutProof,
+        TestMempoolAccept, TransactionCategory, UploadTarget, VerifyChain, VerifyTxOutProof,
         WalletCreateFundedPsbt, WalletCreateFundedPsbtError, WalletProcessPsbt, WitnessUtxo,
     },
     v18::{

types/src/v27/mod.rs

@@ -278,7 +278,7 @@ pub use crate::{
         Locked, PeerInfo, PruneBlockchain, RawTransactionError, RawTransactionInput,
         RawTransactionOutput, RescanBlockchain, SendMany, SendRawTransaction, SendToAddress,
         SignMessage, SignRawTransaction, SignRawTransactionError, SoftforkReject,
-        TestMempoolAccept, TransactionCategory, UploadTarget, VerifyTxOutProof,
+        TestMempoolAccept, TransactionCategory, UploadTarget, VerifyChain, VerifyTxOutProof,
         WalletCreateFundedPsbt, WalletCreateFundedPsbtError, WalletProcessPsbt, WitnessUtxo,
     },
     v18::{

types/src/v28/mod.rs

@@ -285,7 +285,7 @@ pub use crate::{
         Locked, PeerInfo, PruneBlockchain, RawTransactionError, RawTransactionInput,
         RawTransactionOutput, RescanBlockchain, SendMany, SendRawTransaction, SendToAddress,
         SignMessage, SignRawTransaction, SignRawTransactionError, SoftforkReject,
-        TestMempoolAccept, TransactionCategory, UploadTarget, VerifyTxOutProof,
+        TestMempoolAccept, TransactionCategory, UploadTarget, VerifyChain, VerifyTxOutProof,
         WalletCreateFundedPsbt, WalletCreateFundedPsbtError, WalletProcessPsbt, WitnessUtxo,
     },
     v18::{

verify/src/method/v17.rs

@@ -33,7 +33,7 @@ pub const METHODS: &[Method] = &[
     Method::new_no_model("pruneblockchain", "PruneBlockchain", "prune_blockchain"),
     Method::new_nothing("savemempool", "save_mempool"),
     Method::new_modelled("scantxoutset", "ScanTxOutSet", "scan_tx_out_set"),
-    Method::new_bool("verifychain", "verify_chain"),
+    Method::new_no_model("verifychain", "VerifyChain", "verify_chain"),
     Method::new_modelled("verifytxoutproof", "VerifyTxOutProof", "verify_tx_out_proof"),
     // control
     Method::new_no_model("getmemoryinfo", "GetMemoryInfoStats", "get_memory_info"),

verify/src/method/v18.rs

@@ -33,7 +33,7 @@ pub const METHODS: &[Method] = &[
     Method::new_no_model("pruneblockchain", "PruneBlockchain", "prune_blockchain"),
     Method::new_nothing("savemempool", "save_mempool"),
     Method::new_modelled("scantxoutset", "ScanTxOutSet", "scan_tx_out_set"),
-    Method::new_bool("verifychain", "verify_chain"),
+    Method::new_no_model("verifychain", "VerifyChain", "verify_chain"),
     Method::new_modelled("verifytxoutproof", "VerifyTxOutProof", "verify_tx_out_proof"),
     // control
     Method::new_no_model("getmemoryinfo", "GetMemoryInfoStats", "get_memory_info"),

verify/src/method/v19.rs

@@ -34,7 +34,7 @@ pub const METHODS: &[Method] = &[
     Method::new_no_model("pruneblockchain", "PruneBlockchain", "prune_blockchain"),
     Method::new_nothing("savemempool", "save_mempool"),
     Method::new_modelled("scantxoutset", "ScanTxOutSet", "scan_tx_out_set"),
-    Method::new_bool("verifychain", "verify_chain"),
+    Method::new_no_model("verifychain", "VerifyChain", "verify_chain"),
     Method::new_modelled("verifytxoutproof", "VerifyTxOutProof", "verify_tx_out_proof"),
     Method::new_no_model("getrpcinfo", "GetRpcInfo", "get_rpc_info"),
     // control

verify/src/method/v20.rs

@@ -34,7 +34,7 @@ pub const METHODS: &[Method] = &[
     Method::new_no_model("pruneblockchain", "PruneBlockchain", "prune_blockchain"),
     Method::new_nothing("savemempool", "save_mempool"),
     Method::new_modelled("scantxoutset", "ScanTxOutSet", "scan_tx_out_set"),
-    Method::new_bool("verifychain", "verify_chain"),
+    Method::new_no_model("verifychain", "VerifyChain", "verify_chain"),
     Method::new_modelled("verifytxoutproof", "VerifyTxOutProof", "verify_tx_out_proof"),
     Method::new_no_model("getrpcinfo", "GetRpcInfo", "get_rpc_info"),
     // control

verify/src/method/v21.rs

@@ -34,7 +34,7 @@ pub const METHODS: &[Method] = &[
     Method::new_no_model("pruneblockchain", "PruneBlockchain", "prune_blockchain"),
     Method::new_nothing("savemempool", "save_mempool"),
     Method::new_modelled("scantxoutset", "ScanTxOutSet", "scan_tx_out_set"),
-    Method::new_bool("verifychain", "verify_chain"),
+    Method::new_no_model("verifychain", "VerifyChain", "verify_chain"),
     Method::new_modelled("verifytxoutproof", "VerifyTxOutProof", "verify_tx_out_proof"),
     // control
     Method::new_no_model("getmemoryinfo", "GetMemoryInfoStats", "get_memory_info"),

verify/src/method/v22.rs

@@ -34,7 +34,7 @@ pub const METHODS: &[Method] = &[
     Method::new_no_model("pruneblockchain", "PruneBlockchain", "prune_blockchain"),
     Method::new_nothing("savemempool", "save_mempool"),
     Method::new_modelled("scantxoutset", "ScanTxOutSet", "scan_tx_out_set"),
-    Method::new_bool("verifychain", "verify_chain"),
+    Method::new_no_model("verifychain", "VerifyChain", "verify_chain"),
     Method::new_modelled("verifytxoutproof", "VerifyTxOutProof", "verify_tx_out_proof"),
     // control
     Method::new_no_model("getmemoryinfo", "GetMemoryInfoStats", "get_memory_info"),

verify/src/method/v23.rs

@@ -36,7 +36,7 @@ pub const METHODS: &[Method] = &[
     Method::new_no_model("pruneblockchain", "PruneBlockchain", "prune_blockchain"),
     Method::new_no_model("savemempool", "SaveMempool", "save_mempool"),
     Method::new_modelled("scantxoutset", "ScanTxOutSet", "scan_tx_out_set"),
-    Method::new_bool("verifychain", "verify_chain"),
+    Method::new_no_model("verifychain", "VerifyChain", "verify_chain"),
     Method::new_modelled("verifytxoutproof", "VerifyTxOutProof", "verify_tx_out_proof"),
     // control
     Method::new_no_model("getmemoryinfo", "GetMemoryInfoStats", "get_memory_info"),

verify/src/method/v24.rs

@@ -37,7 +37,7 @@ pub const METHODS: &[Method] = &[
     Method::new_no_model("pruneblockchain", "PruneBlockchain", "prune_blockchain"),
     Method::new_no_model("savemempool", "SaveMempool", "save_mempool"),
     Method::new_modelled("scantxoutset", "ScanTxOutSet", "scan_tx_out_set"),
-    Method::new_bool("verifychain", "verify_chain"),
+    Method::new_no_model("verifychain", "VerifyChain", "verify_chain"),
     Method::new_modelled("verifytxoutproof", "VerifyTxOutProof", "verify_tx_out_proof"),
     // control
     Method::new_no_model("getmemoryinfo", "GetMemoryInfoStats", "get_memory_info"),

verify/src/method/v25.rs

@@ -38,7 +38,7 @@ pub const METHODS: &[Method] = &[
     Method::new_no_model("savemempool", "SaveMempool", "save_mempool"),
     Method::new_modelled("scanblocks", "ScanBlocks", "scan_blocks"),
     Method::new_modelled("scantxoutset", "ScanTxOutSet", "scan_tx_out_set"),
-    Method::new_bool("verifychain", "verify_chain"),
+    Method::new_no_model("verifychain", "VerifyChain", "verify_chain"),
     Method::new_modelled("verifytxoutproof", "VerifyTxOutProof", "verify_tx_out_proof"),
     // control
     Method::new_no_model("getmemoryinfo", "GetMemoryInfoStats", "get_memory_info"),

verify/src/method/v26.rs

@@ -42,7 +42,7 @@ pub const METHODS: &[Method] = &[
     Method::new_no_model("savemempool", "SaveMempool", "save_mempool"),
     Method::new_modelled("scanblocks", "ScanBlocks", "scan_blocks"),
     Method::new_modelled("scantxoutset", "ScanTxOutSet", "scan_tx_out_set"),
-    Method::new_bool("verifychain", "verify_chain"),
+    Method::new_no_model("verifychain", "VerifyChain", "verify_chain"),
     Method::new_modelled("verifytxoutproof", "VerifyTxOutProof", "verify_tx_out_proof"),
     // control
     Method::new_no_model("getmemoryinfo", "GetMemoryInfoStats", "get_memory_info"),

verify/src/method/v27.rs

@@ -42,7 +42,7 @@ pub const METHODS: &[Method] = &[
     Method::new_no_model("savemempool", "SaveMempool", "save_mempool"),
     Method::new_modelled("scanblocks", "ScanBlocks", "scan_blocks"),
     Method::new_modelled("scantxoutset", "ScanTxOutSet", "scan_tx_out_set"),
-    Method::new_bool("verifychain", "verify_chain"),
+    Method::new_no_model("verifychain", "VerifyChain", "verify_chain"),
     Method::new_modelled("verifytxoutproof", "VerifyTxOutProof", "verify_tx_out_proof"),
     Method::new_no_model("getrpcinfo", "GetRpcInfo", "get_rpc_info"),
     // control

verify/src/method/v28.rs

@@ -42,7 +42,7 @@ pub const METHODS: &[Method] = &[
     Method::new_no_model("savemempool", "SaveMempool", "save_mempool"),
     Method::new_modelled("scanblocks", "ScanBlocks", "scan_blocks"),
     Method::new_modelled("scantxoutset", "ScanTxOutSet", "scan_tx_out_set"),
-    Method::new_bool("verifychain", "verify_chain"),
+    Method::new_no_model("verifychain", "VerifyChain", "verify_chain"),
     Method::new_modelled("verifytxoutproof", "VerifyTxOutProof", "verify_tx_out_proof"),
     Method::new_no_model("getrpcinfo", "GetRpcInfo", "get_rpc_info"),
     // controll