Skip to content

Commit f005c0f

Browse files
committed
Merge #249: Remove redundant tmp file existence check in wallet integration test
7eb3702 Remove redundant tmp file existence check in wallet integration test (GideonBature) Pull request description: This PR removes the redundant `if file_path.exists()` check before deleting a temporary file. As pointed out during review of `backupwallet` integration test [here](#247 (comment)), the check is unnecessary. ACKs for top commit: tcharding: ACK 7eb3702 Tree-SHA512: d2731742b13fc5395d5f691e131db3008f9738117158ebb0ea2dd2782a647eaba17a5481e7d8875d139ddb1e514ea1cbd6186c7cf935f5adcb7522eee06dc40d
2 parents 4c71c02 + 7eb3702 commit f005c0f

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

integration_test/tests/wallet.rs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -69,10 +69,6 @@ fn wallet__backup_wallet() {
6969
let node = Node::with_wallet(Wallet::Default, &[]);
7070
let file_path = integration_test::random_tmp_file();
7171

72-
if file_path.exists() {
73-
fs::remove_file(&file_path).expect("removefile");
74-
}
75-
7672
node.client.backup_wallet(&file_path).expect("backupwallet");
7773
assert!(file_path.exists(), "Backup file should exist at destination");
7874
assert!(file_path.is_file(), "Backup destination should be a file");

0 commit comments

Comments
 (0)