Skip to content
This repository was archived by the owner on Nov 26, 2024. It is now read-only.

Commit 3725ae0

Browse files
committed
Remove FIXME for missing fields
Investigate and remove the fixme, leave a more terse comment incase someone stumbles upon this later.
1 parent 565cb2a commit 3725ae0

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

json/src/v17/wallet.rs

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -167,13 +167,8 @@ pub struct GetTransaction {
167167
pub amount: f64,
168168
pub fee: Option<f64>,
169169
pub confirmations: u32,
170-
// FIXME: The docs say these two fields should be here but it is not returned.
171-
// Is it worth patching Core for a version this old?
172-
//
173-
// #[serde(rename = "blockhash")]
174-
// pub block_hash: String,
175-
// #[serde(rename = "blockindex")]
176-
// pub block_index: u64,
170+
// The docs say there should be two more fields: `blockhash` and `blockindex` but integration
171+
// test fails if we add them i.e., they are not returned by `v0.17.1`.
177172
pub txid: String,
178173
pub time: u64,
179174
#[serde(rename = "timereceived")]

0 commit comments

Comments
 (0)