Remove FIXME question from getblock

tcharding · tcharding · commit e53251d50f91 · 2024-09-06T13:00:33.000+10:00
We want to provide all shapes of JSON data so having two explicit
functions is a reasonable way, I can't think of a better one right now.
diff --git a/client/src/client_sync/v17/blockchain.rs b/client/src/client_sync/v17/blockchain.rs
@@ -38,9 +38,6 @@ macro_rules! impl_client_v17__getblock {
                 Ok(json.block()?)
             }
 
-            // FIXME(getblock): This handling of optional args is ugly as hell but because the returned json
-            // is different for each verbosity these are functionally different methods. Is there a better way?
-
             pub fn get_block_verbosity_zero(
                 &self,
                 hash: BlockHash,

Original file line number	Diff line number	Diff line change
`@@ -38,9 +38,6 @@ macro_rules! impl_client_v17__getblock {`
`38`	`38`	`Ok(json.block()?)`
`39`	`39`	`}`
`40`	`40`
`41`		`- // FIXME(getblock): This handling of optional args is ugly as hell but because the returned json`
`42`		`- // is different for each verbosity these are functionally different methods. Is there a better way?`
`43`		`-`
`44`	`41`	`pub fn get_block_verbosity_zero(`
`45`	`42`	`&self,`
`46`	`43`	`hash: BlockHash,`