Remove hashbrown dependency

Feature guard implementations of `Satisfier` on `HashMap` on the "std"
feature.

We then no longer require the `hashbrown` dependency sine we use
`BTreeMap` and `BTreeSet` everywhere else.

Author: tcharding

Cargo.toml

@@ -13,7 +13,7 @@ edition = "2018"
 [features]
 default = ["std"]
 std = ["bitcoin/std", "bitcoin/secp-recovery"]
-no-std = ["hashbrown", "bitcoin/no-std"]
+no-std = ["bitcoin/no-std"]
 compiler = []
 trace = []
 
@@ -23,7 +23,6 @@ base64 = ["bitcoin/base64"]
 
 [dependencies]
 bitcoin = { version = "0.30.0", default-features = false }
-hashbrown = { version = "0.11", optional = true }
 internals = { package = "bitcoin-private", version = "0.1.0", default_features = false }
 
 # Do NOT use this as a feature! Use the `serde` feature instead.

src/lib.rs

@@ -100,9 +100,6 @@ pub use bitcoin;
 #[macro_use]
 extern crate alloc;
 
-#[cfg(not(feature = "std"))]
-extern crate hashbrown;
-
 #[cfg(any(feature = "std", test))]
 extern crate core;
 
@@ -961,9 +958,6 @@ mod prelude {
         vec::Vec,
     };
 
-    #[cfg(all(not(feature = "std"), not(test)))]
-    pub use hashbrown::{HashMap, HashSet};
-
     #[cfg(all(not(feature = "std"), not(test)))]
     pub use self::mutex::Mutex;
 }

src/miniscript/satisfy.rs

@@ -172,6 +172,7 @@ impl_satisfier_for_map_key_to_ecdsa_sig! {
 }
 
 impl_satisfier_for_map_key_to_ecdsa_sig! {
+    #[cfg(feature = "std")]
     impl Satisfier<Pk> for HashMap<Pk, bitcoin::ecdsa::Signature>
 }
 
@@ -201,6 +202,7 @@ impl_satisfier_for_map_key_hash_to_taproot_sig! {
 }
 
 impl_satisfier_for_map_key_hash_to_taproot_sig! {
+    #[cfg(feature = "std")]
     impl Satisfier<Pk> for HashMap<(Pk, TapLeafHash), bitcoin::taproot::Signature>
 }
 
@@ -236,6 +238,7 @@ impl_satisfier_for_map_hash_to_key_ecdsa_sig! {
 }
 
 impl_satisfier_for_map_hash_to_key_ecdsa_sig! {
+    #[cfg(feature = "std")]
     impl Satisfier<Pk> for HashMap<hash160::Hash, (Pk, bitcoin::ecdsa::Signature)>
 }
 
@@ -272,6 +275,7 @@ impl_satisfier_for_map_hash_tapleafhash_to_key_taproot_sig! {
 }
 
 impl_satisfier_for_map_hash_tapleafhash_to_key_taproot_sig! {
+    #[cfg(feature = "std")]
     impl Satisfier<Pk> for HashMap<(hash160::Hash, TapLeafHash), (Pk, bitcoin::taproot::Signature)>
 }