Truncate secret hash

The `hex-conservative` crate does not truncate hashes when printed with
the `fmt` precision format parameter, this is as expected since a hash
is a 32 byte integer (I think) and for integral types precision is
ignorded.

Add a private struct to handle truncating, and truncate the hash to an 8
byte identifier.

Author: tcharding

src/secret.rs

@@ -46,7 +46,29 @@ macro_rules! impl_display_secret {
                 engine.input(&self.secret_bytes());
                 let hash = sha256::Hash::from_engine(engine);
 
-                f.debug_tuple(stringify!($thing)).field(&format_args!("#{:016x}", hash)).finish()
+                // hex-conservative does not support truncation and this is the correct behaviour if
+                // a hash is considered integral type. So we truncate manually.
+                //
+                // > Precision
+                // > ...
+                // > For integral types, this is ignored.
+                //
+                // ref: https://doc.rust-lang.org/std/fmt/
+
+                struct Id(&[u8]);
+
+                impl ::core::fmt::Display for Id {
+                    fn fmt(&self, f: &mut ::core::fmt::Formatter) -> ::core::fmt::Result {
+                        for byte in self.0.iter() {
+                            write!(f, "{:02x}", byte)?;
+                        }
+                        Ok(())
+                    }
+                }
+
+                let id = Id(&hash[0..8]);
+
+                f.debug_tuple(stringify!($thing)).field(&format_args!("#{}", id)).finish()
             }
         }