Skip to content

Commit ac897b0

Browse files
lvllvllvllvl
committed
chore: add labels to FIXMEs
1 parent da95caa commit ac897b0

File tree

28 files changed

+87
-78
lines changed

28 files changed

+87
-78
lines changed

‎libc-test/build.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2081,6 +2081,9 @@ fn test_android(target: &str) {
20812081
// Added in API level 26, but some tests use level 24.
20822082
"endgrent" => true,
20832083

2084+
// Added in API level 26, but some tests use level 24.
2085+
"getdomainname" | "setdomainname" => true,
2086+
20842087
// FIXME: bad function pointers:
20852088
"isalnum" | "isalpha" | "iscntrl" | "isdigit" | "isgraph" | "islower" | "isprint"
20862089
| "ispunct" | "isspace" | "isupper" | "isxdigit" | "isblank" | "tolower"

‎libc-test/semver/android.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3324,6 +3324,7 @@ getaddrinfo
33243324
getchar
33253325
getchar_unlocked
33263326
getcwd
3327+
getdomainname
33273328
getegid
33283329
getenv
33293330
geteuid
@@ -3720,6 +3721,7 @@ sendmsg
37203721
sendto
37213722
servent
37223723
setbuf
3724+
setdomainname
37233725
setegid
37243726
setenv
37253727
seteuid

‎src/fuchsia/x86_64.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ cfg_if! {
102102
.field("uc_stack", &self.uc_stack)
103103
.field("uc_mcontext", &self.uc_mcontext)
104104
.field("uc_sigmask", &self.uc_sigmask)
105-
// FIXME: .field("__private", &self.__private)
105+
// FIXME(debug): .field("__private", &self.__private)
106106
.finish()
107107
}
108108
}

‎src/unix/bsd/apple/b32/mod.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ s! {
4747
}
4848

4949
pub struct malloc_zone_t {
50-
__private: [crate::uintptr_t; 18], // FIXME: keeping private for now
50+
__private: [crate::uintptr_t; 18], // FIXME(macos): keeping private for now
5151
}
5252
}
5353

@@ -86,7 +86,7 @@ cfg_if! {
8686
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
8787
f.debug_struct("pthread_attr_t")
8888
.field("__sig", &self.__sig)
89-
// FIXME: .field("__opaque", &self.__opaque)
89+
// FIXME(debug): .field("__opaque", &self.__opaque)
9090
.finish()
9191
}
9292
}

‎src/unix/bsd/apple/b64/aarch64/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ pub type mcontext_t = *mut __darwin_mcontext64;
55

66
s! {
77
pub struct malloc_zone_t {
8-
__private: [crate::uintptr_t; 18], // FIXME: needs arm64 auth pointers support
8+
__private: [crate::uintptr_t; 18], // FIXME(macos): needs arm64 auth pointers support
99
}
1010

1111
pub struct ucontext_t {

‎src/unix/bsd/apple/b64/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ cfg_if! {
8080
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
8181
f.debug_struct("pthread_attr_t")
8282
.field("__sig", &self.__sig)
83-
// FIXME: .field("__opaque", &self.__opaque)
83+
// FIXME(debug): .field("__opaque", &self.__opaque)
8484
.finish()
8585
}
8686
}

‎src/unix/bsd/apple/b64/x86_64/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ s! {
106106
}
107107

108108
pub struct malloc_introspection_t {
109-
_private: [crate::uintptr_t; 16], // FIXME: keeping private for now
109+
_private: [crate::uintptr_t; 16], // FIXME(macos): keeping private for now
110110
}
111111

112112
pub struct malloc_zone_t {

‎src/unix/bsd/apple/mod.rs

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -361,7 +361,7 @@ s! {
361361
}
362362

363363
pub struct sigaction {
364-
// FIXME: this field is actually a union
364+
// FIXME(union): this field is actually a union
365365
pub sa_sigaction: crate::sighandler_t,
366366
pub sa_mask: sigset_t,
367367
pub sa_flags: c_int,
@@ -1304,9 +1304,9 @@ s_no_extra_traits! {
13041304
pub shm_lpid: crate::pid_t,
13051305
pub shm_cpid: crate::pid_t,
13061306
pub shm_nattch: crate::shmatt_t,
1307-
pub shm_atime: crate::time_t, // FIXME: 64-bit wrong align => wrong offset
1308-
pub shm_dtime: crate::time_t, // FIXME: 64-bit wrong align => wrong offset
1309-
pub shm_ctime: crate::time_t, // FIXME: 64-bit wrong align => wrong offset
1307+
pub shm_atime: crate::time_t, // FIXME(macos): 64-bit wrong align => wrong offset
1308+
pub shm_dtime: crate::time_t, // FIXME(macos): 64-bit wrong align => wrong offset
1309+
pub shm_ctime: crate::time_t, // FIXME(macos): 64-bit wrong align => wrong offset
13101310
// FIXME: 64-bit wrong align => wrong offset:
13111311
pub shm_internal: *mut c_void,
13121312
}
@@ -1891,7 +1891,7 @@ cfg_if! {
18911891
.field("pth_curpri", &self.pth_curpri)
18921892
.field("pth_priority", &self.pth_priority)
18931893
.field("pth_maxpriority", &self.pth_maxpriority)
1894-
// FIXME: .field("pth_name", &self.pth_name)
1894+
// FIXME(debug): .field("pth_name", &self.pth_name)
18951895
.finish()
18961896
}
18971897
}
@@ -1957,8 +1957,8 @@ cfg_if! {
19571957
.field("f_fssubtype", &self.f_fssubtype)
19581958
.field("f_fstypename", &self.f_fstypename)
19591959
.field("f_type", &self.f_type)
1960-
// FIXME: .field("f_mntonname", &self.f_mntonname)
1961-
// FIXME: .field("f_mntfromname", &self.f_mntfromname)
1960+
// FIXME(debug): .field("f_mntonname", &self.f_mntonname)
1961+
// FIXME(debug): .field("f_mntfromname", &self.f_mntfromname)
19621962
.field("f_reserved", &self.f_reserved)
19631963
.finish()
19641964
}
@@ -2008,7 +2008,7 @@ cfg_if! {
20082008
.field("d_reclen", &self.d_reclen)
20092009
.field("d_namlen", &self.d_namlen)
20102010
.field("d_type", &self.d_type)
2011-
// FIXME: .field("d_name", &self.d_name)
2011+
// FIXME(debug): .field("d_name", &self.d_name)
20122012
.finish()
20132013
}
20142014
}
@@ -2037,7 +2037,7 @@ cfg_if! {
20372037
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
20382038
f.debug_struct("pthread_rwlock_t")
20392039
.field("__sig", &self.__sig)
2040-
// FIXME: .field("__opaque", &self.__opaque)
2040+
// FIXME(debug): .field("__opaque", &self.__opaque)
20412041
.finish()
20422042
}
20432043
}
@@ -2065,7 +2065,7 @@ cfg_if! {
20652065
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
20662066
f.debug_struct("pthread_mutex_t")
20672067
.field("__sig", &self.__sig)
2068-
// FIXME: .field("__opaque", &self.__opaque)
2068+
// FIXME(debug): .field("__opaque", &self.__opaque)
20692069
.finish()
20702070
}
20712071
}
@@ -2094,7 +2094,7 @@ cfg_if! {
20942094
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
20952095
f.debug_struct("pthread_cond_t")
20962096
.field("__sig", &self.__sig)
2097-
// FIXME: .field("__opaque", &self.__opaque)
2097+
// FIXME(debug): .field("__opaque", &self.__opaque)
20982098
.finish()
20992099
}
21002100
}
@@ -2133,7 +2133,7 @@ cfg_if! {
21332133
.field("ss_family", &self.ss_family)
21342134
.field("__ss_pad1", &self.__ss_pad1)
21352135
.field("__ss_align", &self.__ss_align)
2136-
// FIXME: .field("__ss_pad2", &self.__ss_pad2)
2136+
// FIXME(debug): .field("__ss_pad2", &self.__ss_pad2)
21372137
.finish()
21382138
}
21392139
}
@@ -2173,13 +2173,13 @@ cfg_if! {
21732173
impl fmt::Debug for utmpx {
21742174
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
21752175
f.debug_struct("utmpx")
2176-
// FIXME: .field("ut_user", &self.ut_user)
2176+
// FIXME(debug): .field("ut_user", &self.ut_user)
21772177
.field("ut_id", &self.ut_id)
21782178
.field("ut_line", &self.ut_line)
21792179
.field("ut_pid", &self.ut_pid)
21802180
.field("ut_type", &self.ut_type)
21812181
.field("ut_tv", &self.ut_tv)
2182-
// FIXME: .field("ut_host", &self.ut_host)
2182+
// FIXME(debug): .field("ut_host", &self.ut_host)
21832183
.field("ut_pad", &self.ut_pad)
21842184
.finish()
21852185
}
@@ -2421,7 +2421,7 @@ cfg_if! {
24212421
.field("pth_curpri", &self.pth_curpri)
24222422
.field("pth_priority", &self.pth_priority)
24232423
.field("pth_maxpriority", &self.pth_maxpriority)
2424-
// FIXME: .field("pth_name", &self.pth_name)
2424+
// FIXME(debug): .field("pth_name", &self.pth_name)
24252425
.finish()
24262426
}
24272427
}

‎src/unix/bsd/freebsdlike/dragonfly/mod.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -562,7 +562,7 @@ cfg_if! {
562562
.field("ut_name", &self.ut_name)
563563
.field("ut_id", &self.ut_id)
564564
.field("ut_line", &self.ut_line)
565-
// FIXME: .field("ut_host", &self.ut_host)
565+
// FIXME(debug): .field("ut_host", &self.ut_host)
566566
.field("ut_unused", &self.ut_unused)
567567
.field("ut_session", &self.ut_session)
568568
.field("ut_type", &self.ut_type)
@@ -641,7 +641,7 @@ cfg_if! {
641641
.field("d_type", &self.d_type)
642642
// Ignore __unused1
643643
// Ignore __unused2
644-
// FIXME: .field("d_name", &self.d_name)
644+
// FIXME(debug): .field("d_name", &self.d_name)
645645
.finish()
646646
}
647647
}
@@ -703,10 +703,10 @@ cfg_if! {
703703
.field("f_flags", &self.f_flags)
704704
.field("f_syncwrites", &self.f_syncwrites)
705705
.field("f_asyncwrites", &self.f_asyncwrites)
706-
// FIXME: .field("f_mntonname", &self.f_mntonname)
706+
// FIXME(debug): .field("f_mntonname", &self.f_mntonname)
707707
.field("f_syncreads", &self.f_syncreads)
708708
.field("f_asyncreads", &self.f_asyncreads)
709-
// FIXME: .field("f_mntfromname", &self.f_mntfromname)
709+
// FIXME(debug): .field("f_mntfromname", &self.f_mntfromname)
710710
.finish()
711711
}
712712
}

‎src/unix/bsd/freebsdlike/freebsd/mod.rs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1644,7 +1644,7 @@ s_no_extra_traits! {
16441644
pub kf_flags: c_int,
16451645
_kf_pad0: c_int,
16461646
pub kf_offset: i64,
1647-
_priv: [u8; 304], // FIXME: this is really a giant union
1647+
_priv: [u8; 304], // FIXME(freebsd): this is really a giant union
16481648
pub kf_status: u16,
16491649
_kf_pad1: u16,
16501650
_kf_ispare0: c_int,
@@ -1695,8 +1695,8 @@ cfg_if! {
16951695
.field("ut_pid", &self.ut_pid)
16961696
.field("ut_user", &self.ut_user)
16971697
.field("ut_line", &self.ut_line)
1698-
// FIXME: .field("ut_host", &self.ut_host)
1699-
// FIXME: .field("__ut_spare", &self.__ut_spare)
1698+
// FIXME(debug): .field("ut_host", &self.ut_host)
1699+
// FIXME(debug): .field("__ut_spare", &self.__ut_spare)
17001700
.finish()
17011701
}
17021702
}
@@ -1783,7 +1783,7 @@ cfg_if! {
17831783
.field("sdl_nlen", &self.sdl_nlen)
17841784
.field("sdl_alen", &self.sdl_alen)
17851785
.field("sdl_slen", &self.sdl_slen)
1786-
// FIXME: .field("sdl_data", &self.sdl_data)
1786+
// FIXME(debug): .field("sdl_data", &self.sdl_data)
17871787
.finish()
17881788
}
17891789
}
@@ -2275,7 +2275,7 @@ cfg_if! {
22752275
f.debug_struct("sctp_gen_error_cause")
22762276
.field("code", &{ self.code })
22772277
.field("length", &{ self.length })
2278-
// FIXME: .field("info", &{self.info})
2278+
// FIXME(debug): .field("info", &{self.info})
22792279
.finish()
22802280
}
22812281
}
@@ -2347,7 +2347,7 @@ cfg_if! {
23472347
f.debug_struct("sctp_error_missing_param")
23482348
.field("cause", &{ self.cause })
23492349
.field("num_missing_params", &{ self.num_missing_params })
2350-
// FIXME: .field("tpe", &{self.tpe})
2350+
// FIXME(debug): .field("tpe", &{self.tpe})
23512351
.finish()
23522352
}
23532353
}
@@ -5648,7 +5648,7 @@ extern "C" {
56485648
pub fn pidfile_close(path: *mut crate::pidfh) -> c_int;
56495649
pub fn pidfile_remove(path: *mut crate::pidfh) -> c_int;
56505650
pub fn pidfile_fileno(path: *const crate::pidfh) -> c_int;
5651-
// FIXME: pidfile_signal in due time (both manpage present and updated image snapshot)
5651+
// FIXME(freebsd): pidfile_signal in due time (both manpage present and updated image snapshot)
56525652
}
56535653

56545654
#[link(name = "procstat")]

‎src/unix/bsd/freebsdlike/freebsd/x86_64/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -346,7 +346,7 @@ cfg_if! {
346346
.field("mc_len", &self.mc_len)
347347
.field("mc_fpformat", &self.mc_fpformat)
348348
.field("mc_ownedfp", &self.mc_ownedfp)
349-
// FIXME: .field("mc_fpstate", &self.mc_fpstate)
349+
// FIXME(debug): .field("mc_fpstate", &self.mc_fpstate)
350350
.field("mc_fsbase", &self.mc_fsbase)
351351
.field("mc_gsbase", &self.mc_gsbase)
352352
.field("mc_xfpustate", &self.mc_xfpustate)

‎src/unix/bsd/freebsdlike/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -418,7 +418,7 @@ cfg_if! {
418418
.field("ss_family", &self.ss_family)
419419
.field("__ss_pad1", &self.__ss_pad1)
420420
.field("__ss_align", &self.__ss_align)
421-
// FIXME: .field("__ss_pad2", &self.__ss_pad2)
421+
// FIXME(debug): .field("__ss_pad2", &self.__ss_pad2)
422422
.finish()
423423
}
424424
}

‎src/unix/bsd/netbsdlike/netbsd/mod.rs

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ pub type fsfilcnt_t = u64;
1010
pub type idtype_t = c_int;
1111
pub type mqd_t = c_int;
1212
type __pthread_spin_t = __cpu_simple_lock_nv_t;
13-
pub type vm_size_t = crate::uintptr_t; // FIXME: deprecated since long time
13+
pub type vm_size_t = crate::uintptr_t; // FIXME(deprecated): deprecated since long time
1414
pub type lwpid_t = c_uint;
1515
pub type shmatt_t = c_uint;
1616
pub type cpuid_t = c_ulong;
@@ -297,7 +297,7 @@ s! {
297297
pub flags: u32,
298298
pub fflags: u32,
299299
pub data: i64,
300-
pub udata: intptr_t, /* FIXME: NetBSD 10.0 will finally have same layout as other BSD */
300+
pub udata: intptr_t, /* FIXME(netbsd): NetBSD 10.0 will finally have same layout as other BSD */
301301
}
302302

303303
pub struct dqblk {
@@ -799,7 +799,7 @@ s_no_extra_traits! {
799799
pub ut_session: u16,
800800
pub ut_type: u16,
801801
pub ut_pid: crate::pid_t,
802-
pub ut_exit: __exit_status, // FIXME: when anonymous struct are supported
802+
pub ut_exit: __exit_status, // FIXME(netbsd): when anonymous struct are supported
803803
pub ut_ss: sockaddr_storage,
804804
pub ut_tv: crate::timeval,
805805
pub ut_pad: [u8; _UTX_PADSIZE],
@@ -945,14 +945,14 @@ cfg_if! {
945945
.field("ut_name", &self.ut_name)
946946
.field("ut_id", &self.ut_id)
947947
.field("ut_line", &self.ut_line)
948-
// FIXME .field("ut_host", &self.ut_host)
948+
// FIXME(debug) .field("ut_host", &self.ut_host)
949949
.field("ut_session", &self.ut_session)
950950
.field("ut_type", &self.ut_type)
951951
.field("ut_pid", &self.ut_pid)
952952
.field("ut_exit", &self.ut_exit)
953953
.field("ut_ss", &self.ut_ss)
954954
.field("ut_tv", &self.ut_tv)
955-
// FIXME .field("ut_pad", &self.ut_pad)
955+
// FIXME(debug) .field("ut_pad", &self.ut_pad)
956956
.finish()
957957
}
958958
}
@@ -993,7 +993,7 @@ cfg_if! {
993993
f.debug_struct("lastlogx")
994994
.field("ll_tv", &self.ll_tv)
995995
.field("ll_line", &self.ll_line)
996-
// FIXME.field("ll_host", &self.ll_host)
996+
// FIXME(debug).field("ll_host", &self.ll_host)
997997
.field("ll_ss", &self.ll_ss)
998998
.finish()
999999
}
@@ -1159,7 +1159,7 @@ cfg_if! {
11591159
.field("d_reclen", &self.d_reclen)
11601160
.field("d_namlen", &self.d_namlen)
11611161
.field("d_type", &self.d_type)
1162-
// FIXME: .field("d_name", &self.d_name)
1162+
// FIXME(debug): .field("d_name", &self.d_name)
11631163
.finish()
11641164
}
11651165
}
@@ -1235,8 +1235,8 @@ cfg_if! {
12351235
.field("f_owner", &self.f_owner)
12361236
.field("f_spare", &self.f_spare)
12371237
.field("f_fstypename", &self.f_fstypename)
1238-
// FIXME: .field("f_mntonname", &self.f_mntonname)
1239-
// FIXME: .field("f_mntfromname", &self.f_mntfromname)
1238+
// FIXME(debug): .field("f_mntonname", &self.f_mntonname)
1239+
// FIXME(debug): .field("f_mntfromname", &self.f_mntfromname)
12401240
.finish()
12411241
}
12421242
}
@@ -1290,7 +1290,7 @@ cfg_if! {
12901290
.field("ss_family", &self.ss_family)
12911291
.field("__ss_pad1", &self.__ss_pad1)
12921292
.field("__ss_pad2", &self.__ss_pad2)
1293-
// FIXME: .field("__ss_pad3", &self.__ss_pad3)
1293+
// FIXME(debug): .field("__ss_pad3", &self.__ss_pad3)
12941294
.finish()
12951295
}
12961296
}

‎src/unix/linux_like/emscripten/mod.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1576,8 +1576,6 @@ extern "C" {
15761576
pub fn mkstemps(template: *mut c_char, suffixlen: c_int) -> c_int;
15771577
pub fn nl_langinfo(item: crate::nl_item) -> *mut c_char;
15781578

1579-
pub fn getdomainname(name: *mut c_char, len: size_t) -> c_int;
1580-
pub fn setdomainname(name: *const c_char, len: size_t) -> c_int;
15811579
pub fn sendmmsg(
15821580
sockfd: c_int,
15831581
msgvec: *mut crate::mmsghdr,

‎src/unix/linux_like/linux/gnu/b64/aarch64/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -601,7 +601,7 @@ pub const HWCAP_SSBS: c_ulong = 1 << 28;
601601
pub const HWCAP_SB: c_ulong = 1 << 29;
602602
pub const HWCAP_PACA: c_ulong = 1 << 30;
603603
pub const HWCAP_PACG: c_ulong = 1 << 31;
604-
// FIXME: enable these again once linux-api-headers are up to date enough on CI.
604+
// FIXME(linux): enable these again once linux-api-headers are up to date enough on CI.
605605
// See discussion in https://github.com/rust-lang/libc/pull/1638
606606
//pub const HWCAP2_DCPODP: c_ulong = 1 << 0;
607607
//pub const HWCAP2_SVE2: c_ulong = 1 << 1;

0 commit comments

Comments
 (0)