feat: Virtual macro files

Author: Veykril

Cargo.lock

@@ -3,6 +3,7 @@
 
 use std::fmt;
 
+use rustc_hash::FxHashSet;
 use salsa::Durability;
 use triomphe::Arc;
 use vfs::FileId;
@@ -49,15 +50,25 @@ impl FileChange {
     pub fn apply(self, db: &mut dyn RootQueryDb) -> Option<CratesIdMap> {
         let _p = tracing::info_span!("FileChange::apply").entered();
         if let Some(roots) = self.roots {
+            let mut local_roots = FxHashSet::default();
+            let mut library_roots = FxHashSet::default();
             for (idx, root) in roots.into_iter().enumerate() {
                 let root_id = SourceRootId(idx as u32);
+                if root.is_library {
+                    library_roots.insert(root_id);
+                } else {
+                    local_roots.insert(root_id);
+                }
+
                 let durability = source_root_durability(&root);
                 for file_id in root.iter() {
                     db.set_file_source_root_with_durability(file_id, root_id, durability);
                 }
 
                 db.set_source_root_with_durability(root_id, Arc::new(root), durability);
             }
+            db.set_local_roots_with_durability(Arc::new(local_roots), Durability::MEDIUM);
+            db.set_library_roots_with_durability(Arc::new(library_roots), Durability::MEDIUM);
         }
 
         for (file_id, text) in self.files_changed {

crates/base-db/src/change.rs

@@ -263,6 +263,16 @@ pub trait RootQueryDb: SourceDatabase + salsa::Database {
     #[salsa::invoke(input::transitive_rev_deps)]
     #[salsa::transparent]
     fn transitive_rev_deps(&self, of: Crate) -> FxHashSet<Crate>;
+
+    /// The set of "local" (that is, from the current workspace) roots.
+    /// Files in local roots are assumed to change frequently.
+    #[salsa::input]
+    fn local_roots(&self) -> Arc<FxHashSet<SourceRootId>>;
+
+    /// The set of roots for crates.io libraries.
+    /// Files in libraries are assumed to never change.
+    #[salsa::input]
+    fn library_roots(&self) -> Arc<FxHashSet<SourceRootId>>;
 }
 
 pub fn transitive_deps(db: &dyn SourceDatabase, crate_id: Crate) -> FxHashSet<Crate> {

crates/base-db/src/lib.rs

@@ -519,6 +519,23 @@ impl DefMap {
             .map(|(id, _data)| id)
     }
 
+    pub fn inline_modules_for_macro_file(
+        &self,
+        file_id: MacroCallId,
+    ) -> impl Iterator<Item = LocalModuleId> + '_ {
+        self.modules
+            .iter()
+            .filter(move |(_id, data)| {
+                (match data.origin {
+                    ModuleOrigin::Inline { definition_tree_id, .. } => {
+                        definition_tree_id.file_id().macro_file()
+                    }
+                    _ => None,
+                }) == Some(file_id)
+            })
+            .map(|(id, _data)| id)
+    }
+
     pub fn modules(&self) -> impl Iterator<Item = (LocalModuleId, &ModuleData)> + '_ {
         self.modules.iter()
     }

crates/hir-def/src/nameres.rs

@@ -1068,6 +1068,7 @@ intern::impl_internable!(ModPath, attrs::AttrInput);
 
 #[salsa_macros::interned(no_lifetime, debug, revisions = usize::MAX)]
 #[doc(alias = "MacroFileId")]
+#[derive(PartialOrd, Ord)]
 pub struct MacroCallId {
     pub loc: MacroCallLoc,
 }
@@ -1086,7 +1087,7 @@ impl From<MacroCallId> for span::MacroCallId {
     }
 }
 
-#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash, salsa_macros::Supertype)]
+#[derive(Debug, Clone, Copy, PartialEq, Eq, PartialOrd, Ord, Hash, salsa_macros::Supertype)]
 pub enum HirFileId {
     FileId(EditionedFileId),
     MacroFile(MacroCallId),

crates/hir-expand/src/lib.rs

@@ -20,6 +20,7 @@ pub fn prettify_macro_expansion(
     let span_offset = syn.text_range().start();
     let target_crate = target_crate_id.data(db);
     let mut syntax_ctx_id_to_dollar_crate_replacement = FxHashMap::default();
+
     syntax_bridge::prettify_macro_expansion::prettify_macro_expansion(
         syn,
         &mut |dollar_crate| {

crates/hir-expand/src/prettify_macro_expansion_.rs

@@ -284,18 +284,25 @@ impl<DB: HirDatabase + ?Sized> Semantics<'_, DB> {
         self.imp.resolve_variant(record_lit).map(VariantDef::from)
     }
 
-    pub fn file_to_module_def(&self, file: impl Into<FileId>) -> Option<Module> {
-        self.imp.file_to_module_defs(file.into()).next()
+    pub fn file_to_module_def(&self, file: EditionedFileId) -> Option<Module> {
+        self.imp.ed_file_to_module_defs(file).next()
     }
 
-    pub fn file_to_module_defs(&self, file: impl Into<FileId>) -> impl Iterator<Item = Module> {
-        self.imp.file_to_module_defs(file.into())
+    pub fn file_to_module_def2(&self, file: FileId) -> Option<Module> {
+        self.imp.file_to_module_defs(file).next()
     }
 
     pub fn hir_file_to_module_def(&self, file: impl Into<HirFileId>) -> Option<Module> {
         self.imp.hir_file_to_module_defs(file.into()).next()
     }
 
+    pub fn file_to_module_defs(
+        &self,
+        file: impl Into<EditionedFileId>,
+    ) -> impl Iterator<Item = Module> {
+        self.imp.ed_file_to_module_defs(file.into())
+    }
+
     pub fn hir_file_to_module_defs(
         &self,
         file: impl Into<HirFileId>,
@@ -380,6 +387,19 @@ impl<'db> SemanticsImpl<'db> {
         }
     }
 
+    /// If not crate is found for the file, try to return the last crate in topological order.
+    pub fn first_crate_hir(&self, file: HirFileId) -> Option<Crate> {
+        match file {
+            HirFileId::FileId(editioned_file_id) => {
+                self.first_crate(editioned_file_id.file_id(self.db))
+            }
+            HirFileId::MacroFile(macro_call_id) => {
+                let macro_call = self.db.lookup_intern_macro_call(macro_call_id);
+                Some(macro_call.krate.into())
+            }
+        }
+    }
+
     pub fn attach_first_edition(&self, file: FileId) -> Option<EditionedFileId> {
         Some(EditionedFileId::new(
             self.db,
@@ -412,6 +432,7 @@ impl<'db> SemanticsImpl<'db> {
             HirFileId::FileId(file_id) => {
                 let module = self.file_to_module_defs(file_id.file_id(self.db)).next()?;
                 let def_map = crate_def_map(self.db, module.krate().id);
+
                 match def_map[module.id.local_id].origin {
                     ModuleOrigin::CrateRoot { .. } => None,
                     ModuleOrigin::File { declaration, declaration_tree_id, .. } => {
@@ -770,7 +791,7 @@ impl<'db> SemanticsImpl<'db> {
     // FIXME: Type the return type
     /// Returns the range (pre-expansion) in the string literal corresponding to the resolution,
     /// absolute file range (post-expansion)
-    /// of the part in the format string, the corresponding string token and the resolution if it
+    /// of the part in the format string (post-expansion), the corresponding string token and the resolution if it
     /// exists.
     pub fn check_for_format_args_template_with_file(
         &self,
@@ -904,7 +925,6 @@ impl<'db> SemanticsImpl<'db> {
             None => return res,
         };
         let file = self.find_file(node.syntax());
-
         if first == last {
             // node is just the token, so descend the token
             self.descend_into_macros_all(
@@ -1877,9 +1897,15 @@ impl<'db> SemanticsImpl<'db> {
         self.with_ctx(|ctx| ctx.file_to_def(file).to_owned()).into_iter().map(Module::from)
     }
 
+    fn ed_file_to_module_defs(&self, file: EditionedFileId) -> impl Iterator<Item = Module> {
+        self.with_ctx(|ctx| ctx.file_to_def(file.file_id(self.db)).to_owned())
+            .into_iter()
+            .map(Module::from)
+    }
+
     fn hir_file_to_module_defs(&self, file: HirFileId) -> impl Iterator<Item = Module> {
         // FIXME: Do we need to care about inline modules for macro expansions?
-        self.file_to_module_defs(file.original_file_respecting_includes(self.db).file_id(self.db))
+        self.ed_file_to_module_defs(file.original_file_respecting_includes(self.db))
     }
 
     pub fn scope(&self, node: &SyntaxNode) -> Option<SemanticsScope<'db>> {

crates/hir/src/semantics.rs

@@ -208,7 +208,7 @@ fn replace_usages(
     target_module: &hir::Module,
     delayed_mutations: &mut Vec<(ImportScope, ast::Path)>,
 ) {
-    for (file_id, references) in usages {
+    for (file_id, references) in usages.map_out_of_macros(&ctx.sema) {
         edit.edit_file(file_id.file_id(ctx.db()));
 
         let refs_with_imports = augment_references_with_imports(ctx, references, target_module);

crates/ide-assists/src/handlers/convert_bool_to_enum.rs

@@ -156,7 +156,7 @@ fn edit_struct_references(
     };
     let usages = strukt_def.usages(&ctx.sema).include_self_refs().all();
 
-    for (file_id, refs) in usages {
+    for (file_id, refs) in usages.map_out_of_macros(&ctx.sema) {
         edit.edit_file(file_id.file_id(ctx.db()));
         for r in refs {
             process_struct_name_reference(ctx, r, edit);
@@ -234,7 +234,7 @@ fn edit_field_references(
         };
         let def = Definition::Field(field);
         let usages = def.usages(&ctx.sema).all();
-        for (file_id, refs) in usages {
+        for (file_id, refs) in usages.map_out_of_macros(&ctx.sema) {
             edit.edit_file(file_id.file_id(ctx.db()));
             for r in refs {
                 if let Some(name_ref) = r.name.as_name_ref() {

crates/ide-assists/src/handlers/convert_named_struct_to_tuple_struct.rs

@@ -6,7 +6,7 @@ use ide_db::{
     defs::Definition,
     helpers::mod_path_to_ast,
     imports::insert_use::{ImportScope, insert_use},
-    search::{FileReference, UsageSearchResult},
+    search::{FileReference, RealFileUsageSearchResult},
     source_change::SourceChangeBuilder,
     syntax_helpers::node_ext::{for_each_tail_expr, walk_expr},
 };
@@ -70,7 +70,8 @@ pub(crate) fn convert_tuple_return_type_to_struct(
             let ret_type = edit.make_mut(ret_type);
             let fn_ = edit.make_mut(fn_);
 
-            let usages = Definition::Function(fn_def).usages(&ctx.sema).all();
+            let usages =
+                Definition::Function(fn_def).usages(&ctx.sema).all().map_out_of_macros(&ctx.sema);
             let struct_name = format!("{}Result", stdx::to_camel_case(&fn_name.to_string()));
             let parent = fn_.syntax().ancestors().find_map(<Either<ast::Impl, ast::Trait>>::cast);
             add_tuple_struct_def(
@@ -101,7 +102,7 @@ pub(crate) fn convert_tuple_return_type_to_struct(
 fn replace_usages(
     edit: &mut SourceChangeBuilder,
     ctx: &AssistContext<'_>,
-    usages: &UsageSearchResult,
+    usages: &RealFileUsageSearchResult,
     struct_name: &str,
     target_module: &hir::Module,
 ) {
@@ -231,7 +232,7 @@ fn augment_references_with_imports(
 fn add_tuple_struct_def(
     edit: &mut SourceChangeBuilder,
     ctx: &AssistContext<'_>,
-    usages: &UsageSearchResult,
+    usages: &RealFileUsageSearchResult,
     parent: &SyntaxNode,
     tuple_ty: &ast::TupleType,
     struct_name: &str,