a few small clippy fixes #148667

hkBst · 2025-11-07T20:01:31Z

No description provided.

rustbot · 2025-11-07T20:01:35Z

rustc_errors::emitter was changed

These commits modify compiler targets.
(See the Target Tier Policy.)

rustbot · 2025-11-07T20:01:37Z

rustbot has assigned @JonathanBrouwer.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

hkBst · 2025-11-07T20:02:29Z

compiler/rustc_ast_lowering/src/index.rs

+    // Because we want to track parent items and so forth, enable
+    // deep walking so that we walk nested items in the context of
+    // their outer items.


This seems to be a general comment about all the following visit_nested_* methods, not one in particular.

hkBst · 2025-11-07T20:03:49Z

compiler/rustc_errors/src/emitter.rs

                        // LL + NEWER
                        //    |         <- row_num
-
+                        let snippet = sm.span_to_snippet(part.span).unwrap_or_default();


It isn't used above...

Kivooeo · 2025-11-07T20:28:43Z

Seems like this #t-infra > CI keeps failing because of npm error

Kivooeo · 2025-11-07T20:41:31Z

r=me when npm problem will be fixed and ci is green

@bors delegate+

bors · 2025-11-07T20:41:34Z

✌️ @hkBst, you can now approve this pull request!

If @Kivooeo told you to "r=me" after making some further change, please make that change, then do @bors r=@Kivooeo

hkBst · 2025-11-10T07:31:02Z

@bors r=@Kivooeo

bors · 2025-11-10T07:31:05Z

📌 Commit 244eef6 has been approved by Kivooeo

It is now in the queue for this repository.

JonathanBrouwer · 2025-11-10T07:52:29Z

@bors rollup

a few small clippy fixes

Rollup of 9 pull requests Successful merges: - #148480 (Add `Steal::risky_hack_borrow_mut`) - #148608 (Add test for --test-builder success path) - #148667 (a few small clippy fixes) - #148712 (Port `cfg_select!` to the new attribute parsing system) - #148760 (rustc_target: hide TargetOptions::vendor) - #148775 (Fix a typo in the documentation for the strict_shr function) - #148779 (Implement DynSend and DynSync for std::panic::Location.) - #148781 ([rustdoc] Remove unneeded `allow(rustc::potential_query_instability)`) - #148791 (fix "is_closure_like" doc comment) r? `@ghost` `@rustbot` modify labels: rollup

a few small clippy fixes

Rollup of 16 pull requests Successful merges: - #141470 (Add new `function_casts_as_integer` lint) - #143619 (`c_variadic`: Add future-incompatibility warning for `...` arguments without a pattern outside of `extern` blocks) - #146495 (rustdoc: Erase `#![doc(document_private_items)]`) - #147771 (Rename `*exact_{div,shr,shl}` to `*{div,shr,shl}_exact`) - #147833 (rustdoc-json: move `target` to `json::conversions`) - #147952 (Add a timeout to the `remote-test-client` connection) - #147955 (compiletest: Migrate `TestProps` directive handling to a system of named handlers) - #148480 (Add `Steal::risky_hack_borrow_mut`) - #148506 (Special case detecting `'static` lifetime requirement coming from `-> Box<dyn Trait>`) - #148508 (Provide more context when mutably borrowing an imutably borrowed value) - #148530 (update the bootstrap readme) - #148608 (Add test for --test-builder success path) - #148636 (bootstrap: respect `build.python` on macOS) - #148639 (test(rustdoc): move tests into jump-to-def) - #148647 (Check unsafety for non-macro attributes in `validate_attr`) - #148667 (a few small clippy fixes) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 15 pull requests Successful merges: - #141470 (Add new `function_casts_as_integer` lint) - #143619 (`c_variadic`: Add future-incompatibility warning for `...` arguments without a pattern outside of `extern` blocks) - #146495 (rustdoc: Erase `#![doc(document_private_items)]`) - #147771 (Rename `*exact_{div,shr,shl}` to `*{div,shr,shl}_exact`) - #147833 (rustdoc-json: move `target` to `json::conversions`) - #147955 (compiletest: Migrate `TestProps` directive handling to a system of named handlers) - #148480 (Add `Steal::risky_hack_borrow_mut`) - #148506 (Special case detecting `'static` lifetime requirement coming from `-> Box<dyn Trait>`) - #148508 (Provide more context when mutably borrowing an imutably borrowed value) - #148530 (update the bootstrap readme) - #148608 (Add test for --test-builder success path) - #148636 (bootstrap: respect `build.python` on macOS) - #148639 (test(rustdoc): move tests into jump-to-def) - #148647 (Check unsafety for non-macro attributes in `validate_attr`) - #148667 (a few small clippy fixes) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #148667 - hkBst:clippy-fix-14, r=Kivooeo a few small clippy fixes

Rollup of 15 pull requests Successful merges: - rust-lang/rust#141470 (Add new `function_casts_as_integer` lint) - rust-lang/rust#143619 (`c_variadic`: Add future-incompatibility warning for `...` arguments without a pattern outside of `extern` blocks) - rust-lang/rust#146495 (rustdoc: Erase `#![doc(document_private_items)]`) - rust-lang/rust#147771 (Rename `*exact_{div,shr,shl}` to `*{div,shr,shl}_exact`) - rust-lang/rust#147833 (rustdoc-json: move `target` to `json::conversions`) - rust-lang/rust#147955 (compiletest: Migrate `TestProps` directive handling to a system of named handlers) - rust-lang/rust#148480 (Add `Steal::risky_hack_borrow_mut`) - rust-lang/rust#148506 (Special case detecting `'static` lifetime requirement coming from `-> Box<dyn Trait>`) - rust-lang/rust#148508 (Provide more context when mutably borrowing an imutably borrowed value) - rust-lang/rust#148530 (update the bootstrap readme) - rust-lang/rust#148608 (Add test for --test-builder success path) - rust-lang/rust#148636 (bootstrap: respect `build.python` on macOS) - rust-lang/rust#148639 (test(rustdoc): move tests into jump-to-def) - rust-lang/rust#148647 (Check unsafety for non-macro attributes in `validate_attr`) - rust-lang/rust#148667 (a few small clippy fixes) r? `@ghost` `@rustbot` modify labels: rollup

a few small clippy fixes

244eef6

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 7, 2025

rustbot assigned JonathanBrouwer Nov 7, 2025

hkBst commented Nov 7, 2025

View reviewed changes

Kivooeo assigned Kivooeo and unassigned JonathanBrouwer Nov 7, 2025

Kivooeo approved these changes Nov 7, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

rust-cloud-vms bot force-pushed the clippy-fix-14 branch from 4a4545c to 244eef6 Compare November 9, 2025 17:48

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 10, 2025

Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 10, 2025

Rollup merge of rust-lang#148667 - hkBst:clippy-fix-14, r=Kivooeo

585db8b

a few small clippy fixes

Zalathar mentioned this pull request Nov 10, 2025

Rollup of 8 pull requests #148778

Closed

ChrisDenton added a commit to ChrisDenton/rust that referenced this pull request Nov 10, 2025

Rollup merge of rust-lang#148667 - hkBst:clippy-fix-14, r=Kivooeo

e6cb41c

a few small clippy fixes

ChrisDenton mentioned this pull request Nov 10, 2025

Rollup of 14 pull requests #148800

Closed

ChrisDenton added a commit to ChrisDenton/rust that referenced this pull request Nov 10, 2025

Rollup merge of rust-lang#148667 - hkBst:clippy-fix-14, r=Kivooeo

ea367ce

a few small clippy fixes

ChrisDenton mentioned this pull request Nov 10, 2025

Rollup of 9 pull requests #148802

Closed

Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 11, 2025

Rollup merge of rust-lang#148667 - hkBst:clippy-fix-14, r=Kivooeo

8ed810a

a few small clippy fixes

Zalathar mentioned this pull request Nov 11, 2025

Rollup of 17 pull requests #148810

Closed

Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 11, 2025

Rollup merge of rust-lang#148667 - hkBst:clippy-fix-14, r=Kivooeo

1edec6c

a few small clippy fixes

Zalathar mentioned this pull request Nov 11, 2025

Rollup of 16 pull requests #148813

Closed

Zalathar mentioned this pull request Nov 11, 2025

Rollup of 15 pull requests #148817

Merged

bors merged commit 16944b8 into rust-lang:main Nov 11, 2025
18 of 22 checks passed

rust-timer added a commit that referenced this pull request Nov 11, 2025

Unrolled build for #148667

6098d2f

Rollup merge of #148667 - hkBst:clippy-fix-14, r=Kivooeo a few small clippy fixes

rustbot added this to the 1.93.0 milestone Nov 11, 2025

a few small clippy fixes #148667

a few small clippy fixes #148667

Uh oh!

Conversation

hkBst commented Nov 7, 2025

Uh oh!

rustbot commented Nov 7, 2025

Uh oh!

rustbot commented Nov 7, 2025

Uh oh!

hkBst Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

Kivooeo Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

hkBst Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

Kivooeo commented Nov 7, 2025

Uh oh!

Kivooeo commented Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bors commented Nov 7, 2025

Uh oh!

This comment has been minimized.

hkBst commented Nov 10, 2025

Uh oh!

bors commented Nov 10, 2025

Uh oh!

JonathanBrouwer commented Nov 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Kivooeo commented Nov 7, 2025 •

edited

Loading