Parse profiles in GitHub commands and mention them in help

Author: Kobzol

database/src/lib.rs

@@ -232,6 +232,17 @@ impl Profile {
     pub fn default_profiles() -> Vec<Self> {
         vec![Profile::Check, Profile::Debug, Profile::Doc, Profile::Opt]
     }
+
+    pub fn all_values() -> &'static [Self] {
+        &[
+            Self::Check,
+            Self::Debug,
+            Self::Opt,
+            Self::Doc,
+            Self::DocJson,
+            Self::Clippy,
+        ]
+    }
 }
 
 impl std::str::FromStr for Profile {
@@ -1023,11 +1034,7 @@ impl BenchmarkRequest {
             return Ok(Profile::default_profiles());
         }
 
-        self.profiles
-            .split(',')
-            .map(Profile::from_str)
-            .collect::<Result<Vec<_>, _>>()
-            .map_err(|e| anyhow::anyhow!("Invalid profile: {e}"))
+        parse_profiles(&self.profiles).map_err(|e| anyhow::anyhow!("{e}"))
     }
 
     pub fn is_completed(&self) -> bool {
@@ -1046,6 +1053,13 @@ pub fn parse_backends(backends: &str) -> Result<Vec<CodegenBackend>, String> {
         .collect()
 }
 
+pub fn parse_profiles(profiles: &str) -> Result<Vec<Profile>, String> {
+    profiles
+        .split(',')
+        .map(|s| Profile::from_str(s).map_err(|_| format!("Invalid profile: {s}")))
+        .collect()
+}
+
 /// Cached information about benchmark requests in the DB
 pub struct BenchmarkRequestIndex {
     /// Tags (SHA or release name) of all known benchmark requests

site/frontend/templates/pages/help.html

@@ -49,6 +49,10 @@ <h3><b><code>@rust-timer</code> commands</b></h3>
       rustc-perf will also gather data for this backend for the parent/baseline commit, so that we
       have something to compare to.
     </li>
+    <li><code>profiles=&lt;PROFILES&gt;</code> configures which profiles should be benchmarked.
+      If you select a non-default profile, rustc-perf will also gather data for this profile for the
+      parent/baseline commit, so that we have something to compare to.
+    </li>
   </ul>
   <p><code>@rust-timer build $commit</code> will queue a perf run for the given commit
     <code>$commit</code>.

site/src/request_handlers/github.rs

@@ -6,7 +6,7 @@ use crate::github::{
 use crate::job_queue::should_use_job_queue;
 use crate::load::SiteCtxt;
 
-use database::{parse_backends, BenchmarkRequest, CodegenBackend};
+use database::{parse_backends, parse_profiles, BenchmarkRequest, CodegenBackend, Profile};
 use hashbrown::HashMap;
 use std::sync::Arc;
 
@@ -258,6 +258,7 @@ fn parse_benchmark_parameters<'a>(
         exclude: args.remove("exclude").filter(|s| !s.is_empty()),
         runs: None,
         backends: args.remove("backends").filter(|s| !s.is_empty()),
+        profiles: args.remove("profiles").filter(|s| !s.is_empty()),
     };
     if let Some(runs) = args.remove("runs").filter(|s| !s.is_empty()) {
         let Ok(runs) = runs.parse::<u32>() else {
@@ -278,6 +279,19 @@ fn parse_benchmark_parameters<'a>(
             )
         })?;
     }
+    if let Some(profiles) = &params.profiles {
+        // Make sure that the profiles are correct
+        parse_profiles(profiles).map_err(|e| {
+            format!(
+                "Cannot parse profiles: {e}. Valid values are: {}",
+                Profile::all_values()
+                    .iter()
+                    .map(|b| b.as_str())
+                    .collect::<Vec<_>>()
+                    .join(", ")
+            )
+        })?;
+    }
 
     if !args.is_empty() {
         Err(format!(
@@ -327,6 +341,7 @@ struct BenchmarkParameters<'a> {
     exclude: Option<&'a str>,
     runs: Option<i32>,
     backends: Option<&'a str>,
+    profiles: Option<&'a str>,
 }
 
 pub async fn get_authorized_users() -> Result<Vec<u64>, String> {