Make the ArrayParts struct private.

It's easier inside the library to have ArrayParts be public and have LayoutRef be a type alias. Outside of the library, though, having the ArrayParts be a public interface exposes implementation details. If we ever wanted to switch to a trait object or another approach for DSTs, having ArrayParts be public would make that harder.

Author: akern40

src/arraytraits.rs

@@ -45,7 +45,7 @@ where
     T: AsLayoutRef<A, D> + ?Sized,
 {
     let layout_ref = _a.as_ref();
-    debug_bounds_check!(layout_ref, *_index);
+    debug_bounds_check_ref!(layout_ref, *_index);
 }
 
 /// Access the element at **index**.
@@ -61,11 +61,11 @@ where
     #[inline]
     fn index(&self, index: I) -> &Self::Output
     {
-        debug_bounds_check!(self, index);
+        debug_bounds_check_ref!(self, index);
         unsafe {
-            &*self.ptr.as_ptr().offset(
+            &*self._ptr().as_ptr().offset(
                 index
-                    .index_checked(&self.dim, &self.strides)
+                    .index_checked(&self._dim(), &self._strides())
                     .unwrap_or_else(|| array_out_of_bounds()),
             )
         }
@@ -83,11 +83,11 @@ where
     #[inline]
     fn index_mut(&mut self, index: I) -> &mut A
     {
-        debug_bounds_check!(self, index);
+        debug_bounds_check_ref!(self, index);
         unsafe {
             &mut *self.as_mut_ptr().offset(
                 index
-                    .index_checked(&self.dim, &self.strides)
+                    .index_checked(&self._dim(), &self._strides())
                     .unwrap_or_else(|| array_out_of_bounds()),
             )
         }

src/impl_clone.rs

@@ -7,7 +7,6 @@
 // except according to those terms.
 
 use crate::imp_prelude::*;
-use crate::ArrayParts;
 use crate::ArrayPartsSized;
 use crate::RawDataClone;
 

src/impl_dyn.rs

@@ -31,8 +31,8 @@ impl<A> LayoutRef<A, IxDyn>
     pub fn insert_axis_inplace(&mut self, axis: Axis)
     {
         assert!(axis.index() <= self.ndim());
-        self.dim = self.dim.insert_axis(axis);
-        self.strides = self.strides.insert_axis(axis);
+        self.0.dim = self._dim().insert_axis(axis);
+        self.0.strides = self._strides().insert_axis(axis);
     }
 
     /// Collapses the array to `index` along the axis and removes the axis,
@@ -54,8 +54,8 @@ impl<A> LayoutRef<A, IxDyn>
     pub fn index_axis_inplace(&mut self, axis: Axis, index: usize)
     {
         self.collapse_axis(axis, index);
-        self.dim = self.dim.remove_axis(axis);
-        self.strides = self.strides.remove_axis(axis);
+        self.0.dim = self._dim().remove_axis(axis);
+        self.0.strides = self._strides().remove_axis(axis);
     }
 }