multiboot2: misc

Author: phip1611

multiboot2-header/src/entry_address.rs

@@ -53,7 +53,7 @@ impl Debug for EntryAddressHeaderTag {
             .field("type", &self.typ())
             .field("flags", &self.flags())
             .field("size", &self.size())
-            .field("entry_addr", &(self.entry_addr as *const u32))
+            .field("entry_addr", &self.entry_addr)
             .finish()
     }
 }

multiboot2-header/src/entry_efi_32.rs

@@ -62,7 +62,7 @@ impl Debug for EntryEfi32HeaderTag {
             .field("type", &self.typ())
             .field("flags", &self.flags())
             .field("size", &self.size())
-            .field("entry_addr", &(self.entry_addr as *const u32))
+            .field("entry_addr", &self.entry_addr)
             .finish()
     }
 }

multiboot2-header/src/entry_efi_64.rs

@@ -62,7 +62,7 @@ impl Debug for EntryEfi64HeaderTag {
             .field("type", &self.typ())
             .field("flags", &self.flags())
             .field("size", &self.size())
-            .field("entry_addr", &(self.entry_addr as *const u32))
+            .field("entry_addr", &self.entry_addr)
             .finish()
     }
 }

multiboot2-header/src/relocatable.rs

@@ -108,10 +108,10 @@ impl Debug for RelocatableHeaderTag {
             .field("flags", &self.flags())
             .field("size", &self.size())
             // trick to print this as hexadecimal pointer
-            .field("min_addr", &(self.min_addr as *const u32))
-            .field("max_addr", &(self.max_addr as *const u32))
-            .field("align", &{ self.align })
-            .field("preference", &{ self.preference })
+            .field("min_addr", &self.min_addr)
+            .field("max_addr", &self.max_addr)
+            .field("align", &self.align)
+            .field("preference", &self.preference)
             .finish()
     }
 }

multiboot2/src/boot_information.rs

@@ -132,6 +132,7 @@ impl<'a> BootInformation<'a> {
 
     /// Get the start address of the boot info.
     #[must_use]
+    // TODO deprecated and use pointers only (see provenance discussions)
     pub fn start_address(&self) -> usize {
         self.as_ptr() as usize
     }
@@ -153,6 +154,7 @@ impl<'a> BootInformation<'a> {
     /// let end_addr = boot_info.start_address() + boot_info.total_size();
     /// ```
     #[must_use]
+    // TODO deprecated and use pointers only (see provenance discussions)
     pub fn end_address(&self) -> usize {
         self.start_address() + self.total_size()
     }