Skip to content

Commit f579aee

Browse files
committed
Use more idiomatic interface for AsyncReceiver
1 parent 9ee9a5e commit f579aee

File tree

2 files changed

+14
-12
lines changed

2 files changed

+14
-12
lines changed

src/platform_impl/web/event_loop/proxy.rs

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
use std::future::Future;
2-
use std::pin::Pin;
1+
use std::future;
2+
use std::rc::Rc;
33
use std::sync::mpsc::{self, Receiver, RecvError, SendError, Sender, TryRecvError};
44
use std::sync::{Arc, Mutex};
5-
use std::task::{Context, Poll, Waker};
5+
use std::task::{Poll, Waker};
66

77
use crate::event_loop::EventLoopClosed;
88

@@ -39,7 +39,10 @@ pub fn channel<T: 'static>() -> (AsyncSender<T>, AsyncReceiver<T>) {
3939
sender,
4040
waker: Arc::clone(&waker),
4141
};
42-
let receiver = AsyncReceiver { receiver, waker };
42+
let receiver = AsyncReceiver {
43+
receiver: Rc::new(receiver),
44+
waker,
45+
};
4346

4447
(sender, receiver)
4548
}
@@ -71,15 +74,13 @@ impl<T: 'static> Clone for AsyncSender<T> {
7174
}
7275

7376
pub struct AsyncReceiver<T: 'static> {
74-
receiver: Receiver<T>,
77+
receiver: Rc<Receiver<T>>,
7578
waker: Arc<Mutex<Option<Waker>>>,
7679
}
7780

78-
impl<T: 'static> Future for AsyncReceiver<T> {
79-
type Output = Result<T, RecvError>;
80-
81-
fn poll(self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<Self::Output> {
82-
match self.receiver.try_recv() {
81+
impl<T: 'static> AsyncReceiver<T> {
82+
pub async fn next(&mut self) -> Result<T, RecvError> {
83+
future::poll_fn(|cx| match self.receiver.try_recv() {
8384
Ok(event) => Poll::Ready(Ok(event)),
8485
Err(TryRecvError::Empty) => {
8586
*self.waker.lock().unwrap() = Some(cx.waker().clone());
@@ -91,6 +92,7 @@ impl<T: 'static> Future for AsyncReceiver<T> {
9192
}
9293
}
9394
Err(TryRecvError::Disconnected) => Poll::Ready(Err(RecvError)),
94-
}
95+
})
96+
.await
9597
}
9698
}

src/platform_impl/web/event_loop/runner.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ impl<T: 'static> Shared<T> {
119119
wasm_bindgen_futures::spawn_local({
120120
let runner = this.clone();
121121
async move {
122-
while let Ok(value) = (&mut proxy_receiver).await {
122+
while let Ok(value) = proxy_receiver.next().await {
123123
runner.send_event(Event::UserEvent(value))
124124
}
125125

0 commit comments

Comments
 (0)