From 869c76b9da6fb9f1cb5c3ba7c7e8842834c3da61 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Fri, 18 Nov 2022 14:33:30 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- src/data/01_load_sentences.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/src/data/01_load_sentences.py b/src/data/01_load_sentences.py index eca5e30..b5aac2e 100755 --- a/src/data/01_load_sentences.py +++ b/src/data/01_load_sentences.py @@ -20,7 +20,26 @@ def download_and_load_sts_data(url="http://ixa2.si.ehu.es/stswiki/images/4/48/St wget.download(url, path) with tarfile.open(os.path.join(path, 'Stsbenchmark.tar.gz')) as tar: - tar.extractall(path=path) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, path=path) os.remove(os.path.join(path, 'Stsbenchmark.tar.gz'))