Pitch Bend range not correct when playing from middle

[robertnhart]

When playback is started at a position that is not the beginning of the song, the Pitch Bend range specified at the beginning of the track is not applied.

Example Discord messages

• 2024-10
• 2024-07
• 2023-08 (In this case, we didn't realize it might be related to the playback starting at a position that is not the beginning of the song, but that is probably what it was.)

[robertnhart]

Some initial code investigation...

It looks like the current code is mainly looking for events that cause an effect with one message. The code may need to be expanded to find or remember the most recent RPN Pitch Bend Range amount, which uses a sequence of three messages to cause an effect.

Here is various code I found related to restoring state when the playback is started from a position that is not the beginning.

file app/src/player/EventSource.ts

• function getCurrentStateEvents
  basically just calls getStatusEvents

file app/src/track/selector.ts

• function getStatusEvents
  gets an array of events with events.filter(isControllerEvent).filter(isTickBefore(tick)) then removes duplicates, leaving only the most recent message for each controller. It also uses a similar process to get the most recent tempo, program change, and pitch bend messages.

• function isTickBefore
  defined to just return e.tick <= tick

file app/src/track/identify.ts

• contains the various functions like isControllerEvent that are useful for the filter.