fix(types): reject control characters in bucket names

[shikhar]

Summary

• reject control characters in BucketName::new
• add a unit test covering newline input rejection

Testing

• cargo +nightly fmt
• cargo clippy --all-features --all-targets -- -D warnings --allow deprecated
• cargo nextest run types::tests::bucket_name_rejects_control_characters

Closes #71

[greptile-apps]

Greptile Summary

Added validation to reject control characters in bucket names with a test verifying newline rejection.

• Added char::is_control check to BucketName::new validation
• New test bucket_name_rejects_control_characters covers the validation
• Follows the project's testing conventions (unit tests in same file)
• Consider extending this validation to ObjectKind and ObjectKey types as well

Confidence Score: 4/5

• This PR is safe to merge with minimal risk
• The change adds proper input validation with test coverage. Implementation is clean and follows Rust idioms. Minor consideration: similar types (ObjectKind, ObjectKey) could benefit from the same validation for consistency
• No files require special attention

Important Files Changed

Filename	Overview
src/types.rs	Added control character validation to BucketName::new with corresponding test coverage

_{Last reviewed commit: 14dd5e3}

[greptile-apps]

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}