Skip to content

fix(types): reject control characters in bucket names #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shikhar merged 4 commits into from
Feb 20, 2026
Merged

fix(types): reject control characters in bucket names #84

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
14dd5e3
fix(types): reject control characters in bucket names
shikhar Feb 20, 2026
c1fd614
fix(types): reject control characters in object kinds
shikhar Feb 20, 2026
8c7c870
refactor(types): deduplicate bucket and kind validation
shikhar Feb 20, 2026
d5ece65
Revert "refactor(types): deduplicate bucket and kind validation"
shikhar Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/types.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ impl BucketName {
if name.len() > Self::MAX_LEN {
return Err("Bucket name too long");
}
if name.chars().any(char::is_control) {
return Err("Bucket name cannot contain control characters");
}
Ok(Self(name))
}
}
Expand Down Expand Up @@ -64,6 +67,9 @@ impl ObjectKind {
if key.len() > Self::MAX_LEN {
return Err("Object kind too long");
}
if key.chars().any(char::is_control) {
return Err("Object kind cannot contain control characters");
}
Ok(Self(key))
}
}
Expand Down Expand Up @@ -184,6 +190,18 @@ impl IntoIterator for BucketNameSet {
mod tests {
use super::*;

#[test]
fn bucket_name_rejects_control_characters() {
let result = BucketName::new("bucket\nname");
assert_eq!(result, Err("Bucket name cannot contain control characters"));
}

#[test]
fn object_kind_rejects_control_characters() {
let result = ObjectKind::new("kind\nname");
assert_eq!(result, Err("Object kind cannot contain control characters"));
}

#[test]
fn object_kind_deserialize_rejects_empty() {
let result: Result<ObjectKind, _> = serde_json::from_str(r#""""#);
Expand Down