Is the version deployed at table.sadmn.com really the latest?

[tecoad]

Hi @sadmann7,

Just following up with this project, this commit https://github.com/tecoad/shadcn-table/commit/beed202f0942868e77cba5e9aff61cdcf4a445eb introduced a change on the hook, specifically:

		getFilteredRowModel: enableAdvancedFilter ? undefined : getFilteredRowModel(),
		getFacetedRowModel: enableAdvancedFilter ? undefined : getFacetedRowModel(),
		getFacetedUniqueValues: enableAdvancedFilter ? undefined : getFacetedUniqueValues(),

The thing is, in my fork, the advanced faceted filters are not showing the counts:

{option.withCount && column?.getFacetedUniqueValues()?.get(option.value) && (
	<span className="ml-auto flex size-4 items-center justify-center font-mono text-xs">
		{column?.getFacetedUniqueValues().get(option.value)}
	</span>
)}

Since getFacetedUniqueValues on enableAdvancedFilter is undefined, how is this mean to show the values counter for the advanced toolbar?
The version here https://table.sadmn.com/ is showing it though.

Can you confirm? Any reason for this?

[sadmann7]

need to update the advanced filter

the advanced filter was quite buggy, will update it with all the fixes

[tecoad]

yes, i just noticed it @sadmann7
For example, if you remove the context and hardcode enableAdvancedFilter: true, the counter on faceted filter won't work.
Its quite surprisingly that it is working actually, because of the context initial null default state.

[sadmann7]

updated the advanced filter.

right now faceted filter count showd the actual item count on the db