Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: add the possibility to choose between nimlsp and nimlangserver #131

Open
arkanoid87 opened this issue Oct 18, 2023 · 1 comment

Comments

@arkanoid87
Copy link

There are pro and cons using nimlangserver vs nimlsp. The main difference is that the first runs nimsuggest processes and controls them, just like this extension does internally when selecting "nimsuggest" option, while nimlsp is compiled with parts of nimsuggest inside, and runs without spawning extra nimsuggest processes.

According to my experience, both solutions that spawn nimsuggest happens fail to keep child processes lifetime under control, and sometimes nimsuggest processes accumulates until OOM is triggered on host.

I'm not blaming any solution here, just trying to point out that currently by selecting "lsp" option nimlangserver is executed, and seems that there is no option to switch to nimlsp, which is a good "plan B".

Considering that nimlagserver and numlsp should naturally speak the same protocol, would it be possible to add a selection to pick the desired LSP executable?

Thanks

@saem
Copy link
Owner

saem commented Oct 19, 2023

That's a relatively straightforward PR and it should work, only issue might be one LSP is more feature complete than the other, but over time capability testing could be added to address that. I don't have time to work on it, however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants