Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple-target-in-package support added in 2.5.2 broke git.properties data #259

Closed
plaird opened this issue Jan 8, 2025 · 1 comment
Closed

Comments

@plaird
Copy link
Contributor

plaird commented Jan 8, 2025

In namespacing all springboot macro outputs in #139 I broke support for git.properties files being automatically loaded into the actuator/info endpoint, and any custom use cases users have built for git.properties.

Example: demoapp-git.properties

https://github.com/salesforce/rules_spring/blob/main/springboot/springboot.bzl#L544

The namespaced git.properties filename needs to be renamed to just git.properties as it is copied into the jar. Also, it has been a todo list item to add tests that verify file layouts within the generated springboot jar. Now is a good time to add that.

@plaird plaird changed the title Multiple target in package support added in 2.5.2 broke git.properties data Multiple-target-in-package support added in 2.5.2 broke git.properties data Jan 8, 2025
@plaird
Copy link
Contributor Author

plaird commented Jan 9, 2025

This issue was resolved by #260.

@plaird plaird closed this as completed Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant