fix: node types for process exitCode don't allow string

* chore: bump deps

* fix: node types for process exitCode don't allow string

Author: iowillhoit

package.json

@@ -7,25 +7,25 @@
   "dependencies": {
     "@oclif/core": "^3.26.5",
     "@salesforce/apex-node": "^6.0.0",
-    "@salesforce/core": "^7.0.1",
-    "@salesforce/kit": "^3.1.0",
-    "@salesforce/plugin-info": "^3.2.3",
-    "@salesforce/sf-plugins-core": "^9.0.4",
-    "@salesforce/source-deploy-retrieve": "^11.0.0",
+    "@salesforce/core": "^7.3.5",
+    "@salesforce/kit": "^3.1.1",
+    "@salesforce/plugin-info": "^3.2.7",
+    "@salesforce/sf-plugins-core": "^9.0.7",
+    "@salesforce/source-deploy-retrieve": "^11.4.0",
     "@salesforce/source-tracking": "^6.0.4",
     "@salesforce/ts-types": "^2.0.9",
     "chalk": "^5.3.0"
   },
   "devDependencies": {
-    "@oclif/plugin-command-snapshot": "^5.1.6",
-    "@salesforce/cli-plugins-testkit": "^5.3.1",
+    "@oclif/plugin-command-snapshot": "^5.1.8",
+    "@salesforce/cli-plugins-testkit": "^5.3.2",
     "@salesforce/dev-scripts": "^9.0.0",
-    "@salesforce/plugin-command-reference": "^3.0.82",
-    "@salesforce/source-testkit": "^2.2.7",
+    "@salesforce/plugin-command-reference": "^3.0.83",
+    "@salesforce/source-testkit": "^2.2.10",
     "@salesforce/ts-sinon": "^1.4.19",
     "cross-env": "^7.0.3",
-    "eslint-plugin-sf-plugin": "^1.18.1",
-    "oclif": "^4.10.1",
+    "eslint-plugin-sf-plugin": "^1.18.3",
+    "oclif": "^4.10.4",
     "ts-node": "^10.9.2",
     "typescript": "^5.4.5"
   },

src/formatters/deleteResultFormatter.ts

@@ -10,7 +10,12 @@ import { ensureArray } from '@salesforce/kit';
 import chalk from 'chalk';
 import { StandardColors } from '@salesforce/sf-plugins-core';
 import { DeleteSourceJson, Formatter, TestLevel, isSdrSuccess } from '../utils/types.js';
-import { fileResponseSortFn, getFileResponseSuccessProps, makePathRelative } from '../utils/output.js';
+import {
+  exitCodeAsNumber,
+  fileResponseSortFn,
+  getFileResponseSuccessProps,
+  makePathRelative,
+} from '../utils/output.js';
 import { TestResultsFormatter } from '../formatters/testResultsFormatter.js';
 
 export class DeleteResultFormatter extends TestResultsFormatter implements Formatter<DeleteSourceJson> {
@@ -43,7 +48,7 @@ export class DeleteResultFormatter extends TestResultsFormatter implements Forma
 
   public display(): void {
     this.displayTestResults();
-    if ([0, 69].includes(process.exitCode ?? 0)) {
+    if ([0, 69].includes(exitCodeAsNumber() ?? 0)) {
       const successes: FileResponseSuccess[] = [];
       const fileResponseSuccesses: Map<string, FileResponse> = new Map<string, FileResponse>();
 

src/formatters/sourceConvertResultFormatter.ts

@@ -10,6 +10,7 @@ import { ux } from '@oclif/core';
 import { ConvertResult } from '@salesforce/source-deploy-retrieve';
 import { SfError, Messages } from '@salesforce/core';
 import { ConvertResultJson, Formatter } from '../utils/types.js';
+import { exitCodeAsNumber } from '../utils/output.js';
 
 Messages.importMessagesDirectoryFromMetaUrl(import.meta.url);
 export const convertMessages = Messages.loadMessages('@salesforce/plugin-deploy-retrieve', 'convert.source');
@@ -27,7 +28,7 @@ export class SourceConvertResultFormatter implements Formatter<ConvertResultJson
   }
 
   public display(): void {
-    if ([0, 69].includes(process.exitCode ?? 0)) {
+    if ([0, 69].includes(exitCodeAsNumber() ?? 0)) {
       ux.log(convertMessages.getMessage('success', [this.result.packagePath]));
     } else {
       throw new SfError(convertMessages.getMessage('convertFailed'), 'ConvertFailed');

src/utils/output.ts

@@ -29,6 +29,15 @@ export const fileResponseSortFn = (i: FileResponse, j: FileResponse): number =>
   return i.type > j.type ? 1 : -1;
 };
 
+export const exitCodeAsNumber = (): number | undefined => {
+  try {
+    return typeof process.exitCode === 'string' ? parseInt(process.exitCode, 10) : process.exitCode;
+  } catch {
+    // it *could* be a string that fails to parse to int?
+    return undefined;
+  }
+};
+
 /** oclif table doesn't like "interface" but likes "type".  SDR exports an interface  */
 export const getFileResponseSuccessProps = (
   s: FileResponseSuccess