Merge pull request #1091 from salesforcecli/cd/fix-output-dir

fix: use full output-path on `convert mdapi`

Author: WillieRuemmele

src/commands/project/convert/mdapi.ts

@@ -202,8 +202,13 @@ const ensureFlagPath = async (options: EnsureFsFlagOptions): Promise<string> =>
         throw new SfError(messages.getMessage('InvalidFlagPath', [flagName, path, enoent]), 'InvalidFlagPath');
       }
       const dir = type === 'dir' ? resolvedPath : dirname(resolvedPath);
-      // using as because fs promises always returns a string when recursive is true
-      return fs.promises.mkdir(dir, { recursive: true }) as Promise<string>;
+
+      await fs.promises.mkdir(dir, { recursive: true }).catch((err) => {
+        throw SfError.wrap(err);
+      });
+
+      // `fs.mkdir` will return only the first dir in the path so we return the full path here
+      return dir;
     }
   }
 };

test/nuts/convert/mdapi.nut.ts

@@ -82,14 +82,17 @@ describe('project convert mdapi NUTs', () => {
       expect(fs.existsSync(convertedToSrcPath)).to.be.true;
     });
 
-    it('should convert the dreamhouse project using metadata flag', () => {
+    it('should convert the dreamhouse project using metadata flag', async () => {
       const convertedToSrcPath = path.join(session.dir, 'convertedToSrcPath_metadataFlag');
       const result = execCmd<ConvertMdapiJson>(
         `project:convert:mdapi -r ${convertedToMdPath} -d ${convertedToSrcPath} -m ApexClass --json`
       );
       expect(result.jsonOutput?.status).to.equal(0);
       expect(result.jsonOutput?.result).to.be.an('array').with.length.greaterThan(10);
       expect(fs.existsSync(convertedToSrcPath)).to.be.true;
+
+      const files = await fs.promises.readdir(path.join(convertedToSrcPath, 'main', 'default', 'classes'));
+      expect(files.length).to.equal(result.jsonOutput?.result.length);
     });
 
     it('should convert the dreamhouse project using metadatapath flag', () => {