Skip to content

Conversation

@goldmane
Copy link

What does this PR do?

This PR addresses issue #554 by resolving a double-encoding, allowing the single component preview to properly function.

What issues does this PR fix or reference?

  • A double encoding of the preview URI, causing a 400 error on sf:open
  • Added unit test to scan all params for multiple encodings

@goldmane goldmane requested review from a team as code owners November 21, 2025 18:26
@salesforce-cla
Copy link

Thanks for the contribution! It looks like @egoldman-sfdc is an internal user so signing the CLA is not required. However, we need to confirm this.

@goldmane goldmane marked this pull request as draft November 21, 2025 18:39
@goldmane goldmane marked this pull request as ready for review November 21, 2025 18:40
@rubicn
Copy link

rubicn commented Nov 27, 2025

@egoldman-sfdc
I'm experiencing this exact issue with scratch orgs. Getting a 400 error with the double-encoded URL localdev%252Fpreview. Looking forward to this fix being merged. Thanks for working on this!

@rubicn
Copy link

rubicn commented Dec 2, 2025

Hi @egoldman-sfdc , just checking in on this PR — we’re running into the same 400 error with double-encoded URLs (localdev%252Fpreview). All tests are passing on my side. Would love to get this merged when convenient. Thanks!

@goldmane goldmane requested a review from a team as a code owner December 2, 2025 14:51
@goldmane
Copy link
Author

goldmane commented Dec 4, 2025

@rubicn I'll look into where we're held up, but in the meantime if you want to fix it locally right now, you can pull down the pr branch, build and locally link it

  • clone this repo
  • in that directory, run yarn && yarn build to build the source
  • run sf plugins link . to have the CLI use the plugin from that directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants