Merge branch 'cleanup'

Author: lkrms

.github/workflows/ci.yml

@@ -86,6 +86,13 @@ jobs:
           key: composer-cache-${{ runner.os }}-${{ hashFiles('**/composer.json', '**/composer.lock') }}
           restore-keys: composer-cache-${{ runner.os }}-
 
+      - name: Persist PHPStan cache
+        uses: actions/cache@v4
+        with:
+          path: build/cache/phpstan
+          key: phpstan-cache-${{ runner.os }}-${{ matrix.php-version }}-${{ github.run_id }}
+          restore-keys: phpstan-cache-${{ runner.os }}-${{ matrix.php-version }}-
+
       - name: Install PHP dependencies
         run: composer install --no-interaction --no-progress
 

composer.json

@@ -24,6 +24,7 @@
         "adodb/adodb-php": "^5",
         "analog/analog": "^1",
         "clue/phar-composer": "^1",
+        "ergebnis/phpunit-slow-test-detector": "^2",
         "firebase/php-jwt": "^6",
         "league/oauth2-client": "^2",
         "php-http/psr7-integration-tests": "^1.3",

phpunit.xml.dist

@@ -45,4 +45,15 @@
         name="URI_FACTORY"
         value="Lkrms\Http\HttpFactory" />
   </php>
+  <extensions>
+    <extension class="Ergebnis\PHPUnit\SlowTestDetector\Extension">
+      <arguments>
+        <array>
+          <element key="maximum-duration">
+            <integer>200</integer>
+          </element>
+        </array>
+      </arguments>
+    </extension>
+  </extensions>
 </phpunit>

src/Toolkit/Core/Catalog/CopyFlag.php

@@ -8,6 +8,8 @@
 /**
  * Get::copy() flags
  *
+ * @api
+ *
  * @extends AbstractEnumeration<int>
  */
 final class CopyFlag extends AbstractEnumeration

src/Toolkit/Core/Catalog/EnvFlag.php

@@ -2,12 +2,13 @@
 
 namespace Salient\Core\Catalog;
 
-use Salient\Core\Utility\Env;
 use Salient\Core\AbstractEnumeration;
 
 /**
  * Env::apply() flags
  *
+ * @api
+ *
  * @extends AbstractEnumeration<int>
  */
 final class EnvFlag extends AbstractEnumeration
@@ -33,5 +34,7 @@ final class EnvFlag extends AbstractEnumeration
     /**
      * Apply all recognised values from the environment to the running script
      */
-    public const ALL = self::LOCALE | self::TIMEZONE;
+    public const ALL =
+        EnvFlag::LOCALE
+        | EnvFlag::TIMEZONE;
 }

src/Toolkit/Core/Catalog/JsonDecodeFlag.php

@@ -5,11 +5,13 @@
 use Salient\Core\AbstractEnumeration;
 
 /**
- * json_decode() flags
+ * Json::parse() flags
+ *
+ * @api
  *
  * @extends AbstractEnumeration<int>
  */
-class JsonDecodeFlag extends AbstractEnumeration
+final class JsonDecodeFlag extends AbstractEnumeration
 {
     public const BIGINT_AS_STRING = \JSON_BIGINT_AS_STRING;
     public const INVALID_UTF8_IGNORE = \JSON_INVALID_UTF8_IGNORE;

src/Toolkit/Core/Catalog/JsonEncodeFlag.php

@@ -5,11 +5,13 @@
 use Salient\Core\AbstractEnumeration;
 
 /**
- * json_encode() flags
+ * Json::stringify() flags
+ *
+ * @api
  *
  * @extends AbstractEnumeration<int>
  */
-class JsonEncodeFlag extends AbstractEnumeration
+final class JsonEncodeFlag extends AbstractEnumeration
 {
     public const FORCE_OBJECT = \JSON_FORCE_OBJECT;
     public const INVALID_UTF8_IGNORE = \JSON_INVALID_UTF8_IGNORE;

src/Toolkit/Core/Catalog/QueryFlag.php

@@ -7,6 +7,8 @@
 /**
  * Get::query() flags
  *
+ * @api
+ *
  * @extends AbstractEnumeration<int>
  */
 final class QueryFlag extends AbstractEnumeration

src/Toolkit/Core/Catalog/SortFlag.php

@@ -7,9 +7,11 @@
 /**
  * Sorting flags
  *
+ * @api
+ *
  * @extends AbstractEnumeration<int>
  */
-class SortFlag extends AbstractEnumeration
+final class SortFlag extends AbstractEnumeration
 {
     public const REGULAR = \SORT_REGULAR;
     public const NUMERIC = \SORT_NUMERIC;

src/Toolkit/Core/Concern/HasReadableProperties.php

@@ -2,19 +2,20 @@
 
 namespace Salient\Core\Concern;
 
-use Lkrms\Support\Introspector as IS;
+use Lkrms\Support\Introspector;
 use Salient\Core\Contract\Readable;
 
 /**
  * Implements Readable
  *
- * - If `_get<Property>()` is defined, `__get` will use its return value instead
- *   of returning the value of `<Property>`.
- * - If `_isset<Property>()` is defined, `__isset` will use its return value
- *   instead of returning the value of `isset(<Property>)`.
- * - The existence of `_get<Property>()` implies that `<Property>` is readable,
- *   regardless of {@see HasReadableProperties::getReadableProperties()}'s
- *   return value.
+ * - If `_get<Property>()` is defined, it is called instead of returning the
+ *   value of `<Property>`.
+ * - If `_isset<Property>()` is defined, it is called instead of returning
+ *   `isset(<Property>)`.
+ * - The existence of `_get<Property>()` makes `<Property>` readable, regardless
+ *   of {@see Readable::getReadableProperties()}'s return value.
+ *
+ * @api
  *
  * @see Readable
  */
@@ -30,7 +31,7 @@ public static function getReadableProperties(): array
      */
     private function getProperty(string $action, string $name)
     {
-        return IS::get(static::class)->getPropertyActionClosure($name, $action)($this);
+        return Introspector::get(static::class)->getPropertyActionClosure($name, $action)($this);
     }
 
     /**