Commit cbcd478
committed
Review
- Update constructor and `Process::withShellCommand()` parameters
- Replace `null` input with an empty stream (`STDIN` must now be passed
explicitly via `Process:pipeInput()`)
- Improve robustness and precision of timeout handling and process
termination
- Add setter methods `setCwd()`, `setEnv()`, `setTimeout
()`, `disableOutputCollection()`, `enableOutputCollection()`
- Add `Process::isTerminatedBySignal()`
- In `Process::runWithoutFail()`, throw `ProcessFailedException` when a
process returns a non-zero exit status
- Throw `ProcessTerminatedBySignalException` when a process monitored by
`Process::wait()` is terminated by a signal that isn't a `SIGTERM` or
`SIGKILL` sent after calling `Process::stop()`
- Throw `LogicException` instead of `ProcessException` where
appropriate
- Add `Process::getStats()` metrics
- Fix output collection bugs
- Update testsProcess
1 parent 7788d8d commit cbcd478
File tree
5 files changed
+440
-183
lines changed- src/Toolkit/Core
- Exception
- tests
- fixtures/Toolkit/Core/Process
- unit/Toolkit/Core
5 files changed
+440
-183
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
Lines changed: 8 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
0 commit comments