Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small changes #5

Open
kuhlaid opened this issue Nov 8, 2024 · 1 comment
Open

Small changes #5

kuhlaid opened this issue Nov 8, 2024 · 1 comment

Comments

@kuhlaid
Copy link

kuhlaid commented Nov 8, 2024

Two things I ran into problems with. Nothing big, but just took me a while to figure it out.

In the requirements.txt file, you need to add Werkzeug==2.2.2 otherwise Werkzeug 3.x or greater could install and break the make due to the import statements being incompatible with Werkzeug 3.x.

Also, in the script/setup I had to place quotes around the path to the requirements file using pip install -r "$REPO_DIR/requirements.txt". Without the quotes my path was causing an error due to - being in the path.

I have not had a chance to explore the code, but I appreciate you sharing it. :)

@salimane
Copy link
Owner

salimane commented Nov 8, 2024

I would appreciate a pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants