Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing HashEqLike impl for &T #670

Closed
Veykril opened this issue Feb 5, 2025 · 2 comments · Fixed by #671
Closed

Missing HashEqLike impl for &T #670

Veykril opened this issue Feb 5, 2025 · 2 comments · Fixed by #671
Assignees
@Veykril

Comments

@Veykril
Copy link
Member

Veykril commented Feb 5, 2025

#633 regressed an impl here somewhere
@Veykril Veykril self-assigned this Feb 5, 2025
@ibraheemdev
Copy link
Contributor

The regression I noticed for reference: astral-sh/ruff#15763 (comment).

@Veykril Veykril mentioned this issue Feb 5, 2025
Merged
@ibraheemdev
Copy link
Contributor

Hmm I think this was actually the wrong way around. What we need is HashEqLike<&T> for T.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Veykril Veykril

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Impl HashEqLike<T> for &T Veykril/salsa
2 participants
@Veykril @ibraheemdev