Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature for adding target type option for link/anchor tag in the toolbar #842

Open
jtoloui-ibm opened this issue Aug 12, 2021 · 4 comments
Labels
Milestone

Comments

@jtoloui-ibm
Copy link

Is your feature request related to a problem? Please describe.
When using SCEditor and using link option from the toolbar it doesn't allow a user to select its target type to specific how you wish the link to open the url e.g same window or in a new page or tab.

Describe the solution you'd like
The option within SCEditor dropdown for link to have the choice of the types of target types an anchor tag can have.

Describe alternatives you've considered
Another option I've seen is to go into the code mode and manually edit/add a target attribute however when exiting code mode it reverts those changes

Additional context
N/A

@jtoloui-ibm
Copy link
Author

Hi @samclarke, I've create a fix but it won't let me publish the branch, would it be possible to be allowed to push?

@live627
Copy link
Collaborator

live627 commented Aug 13, 2021 via email

@jtoloui-ibm
Copy link
Author

No my mistake, forking now thanks

@samclarke samclarke added this to the v4.0.0 milestone Aug 13, 2021
@jtoloui-ibm
Copy link
Author

Created a plugin in #844 to include into the next 3.X release being a non breaking change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants