Skip to content

Commit 3da9be0

Browse files
committed
refactor(localization): remove emoji from audio format descriptions for consistency
Signed-off-by: samzong <[email protected]>
1 parent 8973763 commit 3da9be0

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

MacMusicPlayer/Managers/DownloadManager.swift

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -294,12 +294,12 @@ public class DownloadManager {
294294
DownloadFormat(
295295
formatId: "bestaudio",
296296
fileExtension: "mp3",
297-
description: NSLocalizedString("🎵 Best Quality (Auto Select)", comment: "Format description for best audio quality")
297+
description: NSLocalizedString("Best Quality (Auto Select)", comment: "Format description for best audio quality")
298298
),
299299
DownloadFormat(
300300
formatId: "140",
301301
fileExtension: "m4a",
302-
description: NSLocalizedString("🎵 M4A Audio (128kbps, 44kHz, stereo, 3.5MiB) [AAC]", comment: "Predefined format description"),
302+
description: NSLocalizedString("M4A Audio (128kbps, 44kHz, stereo, 3.5MiB) [AAC]", comment: "Predefined format description"),
303303
bitrate: "128kbps",
304304
sampleRate: "44kHz",
305305
channels: NSLocalizedString("stereo", comment: "Audio channel type"),
@@ -308,7 +308,7 @@ public class DownloadManager {
308308
DownloadFormat(
309309
formatId: "251",
310310
fileExtension: "webm",
311-
description: NSLocalizedString("🎵 WebM Audio (160kbps, 48kHz, stereo, 3.2MiB) [Opus]", comment: "Predefined format description"),
311+
description: NSLocalizedString("WebM Audio (160kbps, 48kHz, stereo, 3.2MiB) [Opus]", comment: "Predefined format description"),
312312
bitrate: "160kbps",
313313
sampleRate: "48kHz",
314314
channels: NSLocalizedString("stereo", comment: "Audio channel type"),
@@ -423,7 +423,7 @@ public class DownloadManager {
423423
var description = ""
424424

425425
if !properties.bitrate.isEmpty {
426-
description = String(format: NSLocalizedString("🎵 %@ Audio (%@", comment: "Format description with bitrate"), properties.fileExtension.uppercased(), properties.bitrate)
426+
description = String(format: NSLocalizedString("%@ Audio (%@", comment: "Format description with bitrate"), properties.fileExtension.uppercased(), properties.bitrate)
427427

428428
if !properties.sampleRate.isEmpty {
429429
description += String(format: ", %@", properties.sampleRate)
@@ -437,7 +437,7 @@ public class DownloadManager {
437437

438438
description += ")"
439439
} else {
440-
description = String(format: NSLocalizedString("🎵 %@ Audio", comment: "Format description without details"), properties.fileExtension.uppercased())
440+
description = String(format: NSLocalizedString("%@ Audio", comment: "Format description without details"), properties.fileExtension.uppercased())
441441

442442
if !properties.sampleRate.isEmpty || !properties.channels.isEmpty || !properties.fileSize.isEmpty {
443443
description += " ("

MacMusicPlayer/Resources/Localization/en.lproj/Localizable.strings

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -62,14 +62,14 @@
6262
"Error checking yt-dlp: %@" = "Error checking yt-dlp: %@";
6363
"Error getting video title: %@" = "Error getting video title: %@";
6464
"Getting available formats, URL: %@" = "Getting available formats, URL: %@";
65-
"🎵 Best Quality (Auto Select)" = "🎵 Best Quality (Auto Select)";
65+
"Best Quality (Auto Select)" = "Best Quality (Auto Select)";
6666
"stereo" = "stereo";
6767
"mono" = "mono";
6868
"5.1 channels" = "5.1 channels";
69-
"🎵 %@ Audio (%@" = "🎵 %@ Audio (%@";
70-
"🎵 %@ Audio" = "🎵 %@ Audio";
71-
"🎵 M4A Audio (128kbps, 44kHz, stereo, 3.5MiB) [AAC]" = "🎵 M4A Audio (128kbps, 44kHz, stereo, 3.5MiB) [AAC]";
72-
"🎵 WebM Audio (160kbps, 48kHz, stereo, 3.2MiB) [Opus]" = "🎵 WebM Audio (160kbps, 48kHz, stereo, 3.2MiB) [Opus]";
69+
"%@ Audio (%@" = "%@ Audio (%@";
70+
"%@ Audio" = "%@ Audio";
71+
"M4A Audio (128kbps, 44kHz, stereo, 3.5MiB) [AAC]" = "M4A Audio (128kbps, 44kHz, stereo, 3.5MiB) [AAC]";
72+
"WebM Audio (160kbps, 48kHz, stereo, 3.2MiB) [Opus]" = "WebM Audio (160kbps, 48kHz, stereo, 3.2MiB) [Opus]";
7373
"Failed to get formats: %@" = "Failed to get formats: %@";
7474
"Error getting formats: %@" = "Error getting formats: %@";
7575
"Starting audio download, URL: %@, Format ID: %@" = "Starting audio download, URL: %@, Format ID: %@";

0 commit comments

Comments
 (0)