Skip to content

Peer to peer code review 03-02 #14

@astroboyReloaded

Description

@astroboyReloaded
  • I noticed the live demo is still not working with JavaScript.
  • The HTML in your main branch is still showing the work section.
  • In the popup.js I see you are using a forEach to populate the works section, and you use a var i to keep an index. I think you should use the built in index from the forEach method which is the second parameter of the method.
  • I think it would be a UX plus if you add some transitions to your buttons.
  • In the HTML last section I think you could improve it by putting it in a <footer>.
  • I thinh You could improve the interactivity of your page by adding a hover state to the buttons.
  • Good distribution of your js files, it helps with rendering speed (light weight)
  • Good organization in your HTML and CSS files.
  • I think using variable names in English would help you stay in sync for international collaboration.
  • Is the works section coming from the HTML or the js file?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions