Do not clean up source share server immediately after migration

[chuan137]

After share server migration, the source share server are immediately removed from both backend and in Manila. However, for some reason, the migration needs to be rolled back. We could do another migration in reverse direction. But it would be nice to delay the deletion and prune them later. Especailly, there is a rollback procedure provided by NetApp.

ref:

manila/manila/share/manager.py

Lines 5791 to 5798 in b6b4bdb

	if share_server_was_reused:
	self.driver.deallocate_network(context, source_share_server['id'])
	self.db.share_server_delete(context, source_share_server['id'])
	else:
	source_share_server = self._get_share_server_dict(
	context, source_share_server)
	rpcapi = share_rpcapi.ShareAPI()
	rpcapi.delete_share_server(context, source_share_server)

Edit:
upstream bug: https://bugs.launchpad.net/manila/+bug/2028642

[Carthaca]

Especailly, there is a rollback procedure provided by NetApp.

not yet, putting this on hold until we have something detailed