Incorrect option if context menu is opened while connecting

[dpp-gerrit]

Steps to reproduce:

• Disconnect Saros.
• Reconnect using the "plug" icon
• Before the connection is established: right click on any buddy in your buddy list.
• Keep the context menu open and watch for the change that happens, when the connection is established: The option "Work together on ..." becomes "Add Buddy ..." (while all other options remain the same, see attached screenshot).

If you close and re-open the context menu, you'll see the original context menu with the correct options. I tested this with the current HEAD of the master branch (namely 2cc8af3).
To reproduce and observe this behavior you'll need a not-super-fast connection from outside the Freie Universität. I tested this from within and had no time frame to open the context menu before the connection was up.

Just in case this bug seems familiar to someone: it's a "new version" of #3153248. The old version is outdated since the workflow described there is not available anymore.

Reported by: fzieris

Original Ticket: dpp/bugs/739

[dpp-gerrit]

Original comment by: fzieris

[dpp-gerrit]

Lowered to prio 1.

Reminds me of my old days when playing MMORPG and try to exploit any possible bug to gain any (unfair) advantage.

Normal workflow is:

Login, wait until you contact comes online, invite him.

Seems you were really bored this day to just find such a bug :P

Original comment by: kargor