No files opened: "non-shared file open"

[dpp-gerrit]

Alice has no files open and creates a session with Bob.
In the Roster, Bob sees "non-shared file open" although this is not the case,
there is no file opened at all!

Reported by: arsenij-solovjev

Original Ticket: dpp/bugs/804

[dpp-gerrit]

Regarding the current logic you cannot distinguish between no shared files open and no files open at all.

Original comment by: kargor

[dpp-gerrit]

Prio 2 as it does not make a big difference because you have not open an editor for a shared file in both cases.

Original comment by: kargor

[dpp-gerrit]

This led to considerable confusion in a productive Saros session.

Original comment by: fzieris

[dpp-gerrit]

"This led to considerable confusion in a productive Saros session."

Can you please give me a real example in a "productive Saros session" where it is common that a developer has no editor open at all ? The only time I personally have no open editor is when I hit: "Close All Editors" because I want to get rid of all "garbage editors" which I maybe opened because I was browsing through the code base.

Original comment by: kargor

[dpp-gerrit]

Yes, the scenario you described is very likely. What is missing is the context. The session I have in mind had the following context:

• Alice and Bob work together almost on a daily basis. Bob does not posses all the sourcecode that comprises the project (maybe he doesn't want to, maybe he isn't allowed to), but Alice does. So both developers know, that Alice might scroll through a file that is not part of the session and never should be. She might do that even unwittingly.
• So, in a session where Alice jumps around between different files, for Bob it's worth mentioning to Alice that she opened a file that he can't see. This way, the pair avoids prolonged explanations by Alice concerning that invisible file. That's a healthy behavior and Saros is doing fine here.
• But: If Alice closes all open files (your scenario) and even shortly thinks of how and where to proceed, Bob is alerted (as usual), notifies Alice, and Alice is confused. Both developers assume a malfunction of Saros, lose their train of thought, their trust in Saros's fault prevention and recovery capabilities is lessened, and the world as we know it comes to end.

Yes, I know, I got carried away in the last part. But the principle holds: Even if a simple and short action of Saros unnecessarily arouses the developers' attention, this is a problem we should address. And I don't deem fixing this one to be that expensive.

Original comment by: fzieris

[dpp-gerrit]

Then please feel free to fix it :>

Sometimes the reality shows different results ...

Original comment by: kargor

[dpp-gerrit]

Hello dear Saros team,
my partner Matthias and me would like to fix that bug.
We did send an e-mail with our 2 solution approaches via the mailing list.
(Sunday, 10. November 2013 21:52, [DPP-Devel] Bug #804)
Please let us know if you have any suggestions concerning our approaches.
We would appreciate any kind of feedback.

Kind regards,
Matthias Kupferschmidt and Georg Müller

Original comment by: fu-georgm