Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Rule: Selector Validity #328

Open
benthemonkey opened this issue Oct 18, 2015 · 3 comments
Open

New Rule: Selector Validity #328

benthemonkey opened this issue Oct 18, 2015 · 3 comments
Labels

Comments

@benthemonkey
Copy link
Member

(Should the name be valid-selector? selector-validity? no-invalid-selectors?)

This rule checks that all selectors (classes, IDs, etc) adhere to the W3 spec for valid css identifiers

See #327 for a discussion about adding this rule.

@BPScott
Copy link

BPScott commented Oct 18, 2015

I'll vote for no-invalid-selectors, the convention seems to be no-disallowed-thing, for instance there is already a no-invalid-hex.

@Snugug
Copy link
Member

Snugug commented Oct 18, 2015

no-disallowed-thing

On Oct 18, 2015, at 2:34 PM, Ben Scott [email protected] wrote:

I'll vote for no-invalid-selectors, the convention seems to be no-disallowed-thing, for instance there is already a no-invalid-hex.


Reply to this email directly or view it on GitHub.

@Snugug
Copy link
Member

Snugug commented Nov 15, 2015

HTML5 is HTML, spec to that, and have an option to "degrade" to HTML4

On Nov 14, 2015, at 8:47 PM, Ben Rothman [email protected] wrote:

According to my brief research, IDs have different constraints in HTML4 vs HTML5. Should I include an option here to specify the spec? I'm leaning toward the rule simply testing adherence to HTML4, as my general use case is writing code to test with latest Chrome, only to run into subtle problems with IE8. Also constraints on IDs are pretty lax with HTML5.


Reply to this email directly or view it on GitHub.

@Snugug Snugug modified the milestones: 1.4.0, 1.5/0 Nov 16, 2015
@DanPurdy DanPurdy modified the milestones: 1.5.0, 1.6.0 Jan 28, 2016
@DanPurdy DanPurdy modified the milestone: 1.7.0 May 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants