Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Rule: Indent Map #35

Open
Snugug opened this issue Aug 28, 2015 · 4 comments
Open

New Rule: Indent Map #35

Snugug opened this issue Aug 28, 2015 · 4 comments
Labels

Comments

@Snugug
Copy link
Member

Snugug commented Aug 28, 2015

Ensure maps are indented when defined in variables

@Snugug Snugug added the rule label Aug 28, 2015
@Snugug Snugug added this to the 1.3.0 milestone Sep 6, 2015
@DanPurdy DanPurdy modified the milestones: 1.4.0, 1.3.0 Oct 7, 2015
@DanPurdy
Copy link
Member

Indentation now works correctly with maps in PR #289

Would a separate rule be necessary here?

@bgriffith
Copy link
Member

Could you potentially want to allow or disallow single-line maps? Is that a different rule again?

@DanPurdy
Copy link
Member

Hey @Snugug could you confirm what this rule would do. Thanks!

@Snugug
Copy link
Member Author

Snugug commented Oct 28, 2015

Yah, the rule would disallow single line maps. The question I have now that I reread this is it should just be in variable definitions or everywhere maps are used (mixin and function arguments come to mind, but that could also reek havoc with indentation rule, maybe)

@DanPurdy DanPurdy removed this from the 1.4.0 milestone Nov 2, 2015
@Snugug Snugug modified the milestones: 1.4.0, 1.5/0 Nov 16, 2015
@DanPurdy DanPurdy modified the milestones: 1.5.0, 1.6.0 Jan 28, 2016
@DanPurdy DanPurdy removed this from the 1.7.0 milestone May 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants