Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate the viability of ESLint compatible rules #5

Open
xzyfer opened this issue Feb 18, 2015 · 5 comments
Open

Investigate the viability of ESLint compatible rules #5

xzyfer opened this issue Feb 18, 2015 · 5 comments

Comments

@xzyfer
Copy link
Member

xzyfer commented Feb 18, 2015

It'd be rad if we could have rules that are interchangeable with ESLint.

If we do it right we could be able to share many style central rules i.e. like trailing commas, white space after commas etc..

These shouldn't require any Sass specific logic depending on the level of AST abstraction within the ESLint API.

@xzyfer
Copy link
Member Author

xzyfer commented Feb 18, 2015

From a cursory look, we could apply some the no-comma-dangle rule to Sass data types with a very thin adapter layer.

@xzyfer xzyfer changed the title Investigate the viability of ESLint compatible plugins Investigate the viability of ESLint compatible rules Feb 18, 2015
@Snugug
Copy link
Member

Snugug commented Feb 18, 2015

👍

@Snugug Snugug mentioned this issue Feb 18, 2015
7 tasks
@Snugug Snugug added the on hold label Aug 28, 2015
@benthemonkey
Copy link
Member

If this were implemented, wouldn't sass-lint also get a performance bump from doing only a single traversal of the AST, and having rules attached themselves to specific nodes?

@xzyfer
Copy link
Member Author

xzyfer commented Oct 7, 2015

@benthemonkey the original intent was to lint in a single pass. In order to get 1.0 out we took a more naive approach for the sake of getting things done.

Considering the pace the rules have been implemented, I'm not convinced this issue in it's original intent, makes sense anymore.

I expect for v2 we'll adopt an architecture similar to eslint, which allow single pass linting for most (all?) rules. It would be at this point we'd implement pluggable rules.

@DanPurdy
Copy link
Member

DanPurdy commented Oct 7, 2015

This makes sense to me a single pass would be pretty good. Hopefully as you say with the speed the rules have been added we shouldn't be far off of parity with scss-lint (and then some!) so work on v2.0 could happen fairly soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants