-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate the viability of ESLint compatible rules #5
Comments
From a cursory look, we could apply some the no-comma-dangle rule to Sass data types with a very thin adapter layer. |
👍 |
If this were implemented, wouldn't sass-lint also get a performance bump from doing only a single traversal of the AST, and having rules attached themselves to specific nodes? |
@benthemonkey the original intent was to lint in a single pass. In order to get 1.0 out we took a more naive approach for the sake of getting things done. Considering the pace the rules have been implemented, I'm not convinced this issue in it's original intent, makes sense anymore. I expect for v2 we'll adopt an architecture similar to eslint, which allow single pass linting for most (all?) rules. It would be at this point we'd implement pluggable rules. |
This makes sense to me a single pass would be pretty good. Hopefully as you say with the speed the rules have been added we shouldn't be far off of parity with scss-lint (and then some!) so work on v2.0 could happen fairly soon. |
It'd be rad if we could have rules that are interchangeable with ESLint.
If we do it right we could be able to share many style central rules i.e. like trailing commas, white space after commas etc..
These shouldn't require any Sass specific logic depending on the level of AST abstraction within the ESLint API.
The text was updated successfully, but these errors were encountered: