Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO #2

Open
5 of 13 tasks
alexeyr opened this issue Mar 22, 2018 · 0 comments
Open
5 of 13 tasks

TODO #2

alexeyr opened this issue Mar 22, 2018 · 0 comments

Comments

@alexeyr
Copy link
Contributor

alexeyr commented Mar 22, 2018

  • SUnitDef can be created and passed to Scalanizer without corresponding UnitConfig, so path information is lost.

  • @throws[Exception] annotation is not in SMethodDef.annotations.

  • SAnnotation needs typeArgs (e.g. @throws[SomeException]).

  • From Enums.scalan:

    trait NanPropagationCompanion {
      val `NonPropagate `: Rep[NanPropagation] = NanPropagation(toRep(1.asInstanceOf[Int]));
      def NonPropagate: Rep[NanPropagation] = NanPropagation.this.`NonPropagate `;
      val `Propagate `: Rep[NanPropagation] = NanPropagation(toRep(2.asInstanceOf[Int]));
      def Propagate: Rep[NanPropagation] = NanPropagation.this.`Propagate `
    }
    
  • enumeration name lost: for SomeEnumeration.Value, parser produces STraitCall("Value", Nil). I think this is because in ScalanParsers, you have

    case select: Select =>
      STraitCall(select.name, List())
    
  • Big issue, can be delayed: in STraitCall we only have name as String, it should probably be SSymbol. Otherwise we can't distinguish two classes with same names in different packages, class A from type parameter A, etc.

  • Why do we want

      case STpePrimitive(name, _) => STraitCall(name, List())
    

    in traitCall? And more generally, STraitCalls with empty type param lists?

  • Lower type bound is ignored in def tpeArg(tdTree: TypeDef).

  • Equivalent to RefTreeApi: SIdent, SSelect, and STpeSelectFromTT need to carry SSymbols they reference.

  • Type of DnnExample.ctx is represented as Some(STpeSingle(STpeThis(DnnExample),ctx)), expected Some(STraitCall(DnnContext)).

  • Also from previous, it should be STpeThis(fullNameString: String). DnnExample is not full name. STpeThis should carry an SSymbol instead of/in addition to String as well.

  • Add SThrow.

  • When reading Cols.scala from a dependency, types aren't set properly. Even 1 is parsed as SConst(1, None).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant