Skip to content

Conversation

@francoisferrand
Copy link
Contributor

The capabilities returned by getCapabilities API will not be directly
set in config by ZKOP, so that they are simply served by Cloudserver.

Old fields are keps for backwards compatibility, but the goal is really
that ZKOP is free to put any content there, as needed by pensieve-api:
this will in particular help to minimize the changes required when
adding a new kind of location.

Issue: CLDSRV-599

The capabilities returned by getCapabilities API will not be directly
set in config by ZKOP, so that they are simply _served_ by Cloudserver.

Old fields are keps for backwards compatibility, but the goal is really
that ZKOP is free to put _any_ content there, as needed by pensieve-api:
this will in particular help to minimize the changes required when
adding a new kind of location.

Issue: CLDSRV-599
@bert-e
Copy link
Contributor

bert-e commented Dec 3, 2025

Hello francoisferrand,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Dec 3, 2025

Incorrect fix version

The Fix Version/s in issue CLDSRV-599 contains:

  • 9.0.33

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.1.7

  • 9.2.6

Please check the Fix Version/s of CLDSRV-599, or the target
branch of this pull request.

@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.12%. Comparing base (b3a3444) to head (dce5fbe).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
lib/Config.js 25.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
lib/utilities/reportHandler.js 69.26% <100.00%> (+2.42%) ⬆️
lib/Config.js 79.34% <25.00%> (-0.25%) ⬇️
@@               Coverage Diff                @@
##           development/9.1    #6021   +/-   ##
================================================
  Coverage            84.12%   84.12%           
================================================
  Files                  193      193           
  Lines                12337    12356   +19     
================================================
+ Hits                 10378    10394   +16     
- Misses                1959     1962    +3     
Flag Coverage Δ
ceph-backend-test 64.71% <4.76%> (-0.10%) ⬇️
file-ft-tests 66.97% <47.61%> (-0.04%) ⬇️
kmip-ft-tests 27.09% <4.76%> (-0.04%) ⬇️
mongo-v0-ft-tests 68.26% <47.61%> (-0.07%) ⬇️
mongo-v1-ft-tests 68.27% <47.61%> (-0.05%) ⬇️
multiple-backend 34.26% <4.76%> (-0.05%) ⬇️
sur-tests 34.61% <4.76%> (-0.05%) ⬇️
sur-tests-inflights 36.52% <4.76%> (-0.09%) ⬇️
unit 69.57% <85.71%> (+0.02%) ⬆️
utapi-v2-tests 33.40% <4.76%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

};
const caps = getCapabilities(cfg);

// locationTypeLocal should be false due to env variable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// locationTypeLocal should be false due to env variable

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for next one 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants