-
Notifications
You must be signed in to change notification settings - Fork 252
Serve capabilities from config if present #6021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development/9.1
Are you sure you want to change the base?
Conversation
The capabilities returned by getCapabilities API will not be directly set in config by ZKOP, so that they are simply _served_ by Cloudserver. Old fields are keps for backwards compatibility, but the goal is really that ZKOP is free to put _any_ content there, as needed by pensieve-api: this will in particular help to minimize the changes required when adding a new kind of location. Issue: CLDSRV-599
Hello francoisferrand,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
Codecov Report❌ Patch coverage is
Additional details and impacted files
@@ Coverage Diff @@
## development/9.1 #6021 +/- ##
================================================
Coverage 84.12% 84.12%
================================================
Files 193 193
Lines 12337 12356 +19
================================================
+ Hits 10378 10394 +16
- Misses 1959 1962 +3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
| }; | ||
| const caps = getCapabilities(cfg); | ||
|
|
||
| // locationTypeLocal should be false due to env variable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| // locationTypeLocal should be false due to env variable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same for next one 🙏
The capabilities returned by getCapabilities API will not be directly
set in config by ZKOP, so that they are simply served by Cloudserver.
Old fields are keps for backwards compatibility, but the goal is really
that ZKOP is free to put any content there, as needed by pensieve-api:
this will in particular help to minimize the changes required when
adding a new kind of location.
Issue: CLDSRV-599