Skip to content

enhanced error handling for open weather API errors #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anveshthakur wants to merge 3 commits into
base: master
Choose a base branch
from
Open

enhanced error handling for open weather API errors #192

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e15d5e
enhanced error handling for openweathermap api errors
anveshthakur Sep 28, 2024
eb56ff3
changed Cod to Code and removed the extra else from fetch fn
anveshthakur Oct 6, 2024
fdb55e2
changed the Cod to Code from Unmarshal fn
anveshthakur Oct 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 54 additions & 5 deletions backends/openweathermap.org.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,15 @@ import (
"encoding/json"
"flag"
"fmt"
"github.com/schachmat/wego/iface"
"io"
"log"
"net/http"
"regexp"
"strconv"
"strings"
"time"

"github.com/schachmat/wego/iface"
)

type openWeatherConfig struct {
Expand All @@ -22,12 +24,12 @@ type openWeatherConfig struct {
type openWeatherResponse struct {
Cod string `json:"cod"`
City struct {
Name string `json:"name"`
Country string `json:"country"`
TimeZone int64 `json: "timezone"`
Name string `json:"name"`
Country string `json:"country"`
TimeZone int64 `json: "timezone"`
// sunrise/sunset are once per call
SunRise int64 `json: "sunrise"`
SunSet int64 `json: "sunset"`
SunSet int64 `json: "sunset"`
} `json:"city"`
List []dataBlock `json:"list"`
}
Expand Down Expand Up @@ -55,6 +57,15 @@ type dataBlock struct {
} `json:"rain"`
}

type openWeatherErrorReponse struct {
Code any `json:"cod"`
Message string `json:"message"`
}

func (e openWeatherErrorReponse) Error() string {
return fmt.Sprintf("Error Response from openweathermap.org (%v): %s", e.Code, e.Message)
}

const (
openweatherURI = "http://api.openweathermap.org/data/2.5/forecast?%s&appid=%s&units=metric&lang=%s"
)
Expand Down Expand Up @@ -83,6 +94,11 @@ func (c *openWeatherConfig) fetch(url string) (*openWeatherResponse, error) {
fmt.Printf("Response (%s):\n%s\n", url, string(body))
}

if res.StatusCode != 200 {
err = openWeatherErrorReponseHandler(body, url)
return nil, err
}

var resp openWeatherResponse
if err = json.Unmarshal(body, &resp); err != nil {
return nil, fmt.Errorf("Unable to unmarshal response (%s): %v\nThe json body is: %s", url, err, string(body))
Expand All @@ -93,6 +109,39 @@ func (c *openWeatherConfig) fetch(url string) (*openWeatherResponse, error) {
return &resp, nil
}

func openWeatherErrorReponseHandler(body []byte, url string) error {
var resp openWeatherErrorReponse

if err := resp.UnmarshalJSON(body); err != nil {
return fmt.Errorf("Unable to unmarshal error response (%s): %v\nThe json body is: %s", url, err, string(body))
}

return resp
}

func (r *openWeatherErrorReponse) UnmarshalJSON(data []byte) error {
var raw struct {
Code interface{} `json:"cod"`
Message string `json:"message"`
}

if err := json.Unmarshal(data, &raw); err != nil {
return err
}

switch v := raw.Code.(type) {
case string:
r.Code = v
case float64:
r.Code = strconv.Itoa(int(v))
default:
return fmt.Errorf("unexpected cod type")
}

r.Message = raw.Message
return nil
}

func (c *openWeatherConfig) parseDaily(dataInfo []dataBlock, numdays int) []iface.Day {
var forecast []iface.Day
var day *iface.Day
Expand Down