Do not adjust logos for viewing in dark mode #679
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

The code originating from the PST stylesheets here:
scientific-python-hugo-theme/assets/theme-css/pst/variables/_color.scss
Lines 305 to 320 in 762065e
dark-lightclass to all logos to ensure compliance with that rule. I view this as a bug and as an unintended side effect of using these stylesheets, as I believe it would be better for us to leave the decision to adjust logos in dark mode to the respective projects through their own stylesheets.This is another one of the current dark mode issues; xref #618. Another piece of reasoning behind this: our dark mode support is already pretty sensitive, and we don't want projects' logos to inadvertently break WCAG 1.4.3 when switching to dark mode if their colours are very close to the minimum-contrast threshold!
P.S. I thought about removing this code section from the stylesheets I linked above entirely, but since it's coming from the PST, I decided not to, assuming there must be a reason they included it, and deviating from the PST styles in general warrants a separate discussion elsewhere.
BEFORE
AFTER