Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make run and docs commands fail with more accurate instructions #264

Closed
stefanv opened this issue Jan 21, 2025 · 1 comment
Closed

Make run and docs commands fail with more accurate instructions #264

stefanv opened this issue Jan 21, 2025 · 1 comment

Comments

@stefanv
Copy link
Member

stefanv commented Jan 21, 2025

We should not propage errors, such as FileNotFound, through to the user.

For run, this means not telling the user to file spin bugs. For other commands, just try and catch as many known exceptions and give helpful feedback.

xref: #260 #262

@stefanv
Copy link
Member Author

stefanv commented Feb 11, 2025

Since we launch subprocess for run, that one should not be a problem. The issue that prompted this was actually a custom command that raised internally, because it did not check for the presence of the binary it called. I clarified the error message shown by spin in that case in #266

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant