Skip to content

Add scikit-build-core #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
7 tasks done
matthewfeickert opened this issue Mar 27, 2025 · 11 comments
Closed
7 tasks done

Add scikit-build-core #124

matthewfeickert opened this issue Mar 27, 2025 · 11 comments
Assignees

Comments

@matthewfeickert
Copy link
Member

matthewfeickert commented Mar 27, 2025

(Moving from scikit-build/scikit-build-core#1033)

@LecrisUT @henryiii Please have a member of the scikit-build-core team complete the missing items from the checklist to get started.

image

If you'd also like to use the scientific/upload-nightly-action GitHub Action please check out the action repo's README. If you need to collect wheels from different CI jobs, consider creating a new GitHub Actions workflow with logic similar to matplotlib's or Awkward's.

If you have any questions please just ask here!

@henryiii
Copy link

Is that supposed to be an org account or a personal account? I've had an personal Anaconda account henryiii for 9 years and 5 months. :)

@matthewfeickert
Copy link
Member Author

Is that supposed to be an org account or a personal account? I've had an personal Anaconda account henryiii for 9 years and 5 months. :)

Good question: Personal account. So, https://anaconda.org/henryiii will work fine.

@matthewfeickert
Copy link
Member Author

@henryiii I seeded the project (https://anaconda.org/scientific-python-nightly-wheels/scikit_build_core) with the latest wheel from PyPI and added you as an admin. So once you generate an API token you should be good to go for uploading nightly wheels. Please let us know here once you've done so (and at that point you can feel free to delete the 0.11.1 wheel that is there now.

@matthewfeickert
Copy link
Member Author

@henryiii Just checking in to see if you have any questions on this.

@henryiii
Copy link

henryiii commented May 9, 2025

I've generated and added the token.

@matthewfeickert
Copy link
Member Author

I've generated and added the token.

Great. Are you planning to add a GitHub Actions workflow to upload nightly releases?

@henryiii
Copy link

How often should I upload nightlies? Every night if there are changes? Do you have an example of something similar (a lightweight Python only package, ideally)?

@matthewfeickert
Copy link
Member Author

matthewfeickert commented May 15, 2025

@henryiii yes, as frequently as possible. It is okay to even have a cron job that does so nightly regardless of changes. I'm on my phone as I'm heading to the airport, but both Awkward and Uproot have workflows that do this.

Also c.f. the comment in the checklist post RE: collection workflows.

henryiii added a commit to scikit-build/scikit-build-core that referenced this issue May 15, 2025
See
scientific-python/upload-nightly-action#124.

---------

Signed-off-by: Henry Schreiner <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Copilot <[email protected]>
@matthewfeickert
Copy link
Member Author

matthewfeickert commented May 16, 2025

Thanks @henryiii! With PR scikit-build/scikit-build-core#1081 merged in you're now uploading nightly wheels and everything is good to go. 👍 I'll close this out now.

$ python -m pip install --upgrade --pre --index-url https://pypi.anaconda.org/scientific-python-nightly-wheels/simple --extra-index-url https://pypi.org/simple scikit-build-core
Looking in indexes: https://pypi.anaconda.org/scientific-python-nightly-wheels/simple, https://pypi.org/simple
Collecting scikit-build-core
  Downloading https://pypi.anaconda.org/scientific-python-nightly-wheels/simple/scikit-build-core/0.11.3.dev11%2Bg501625f/scikit_build_core-0.11.3.dev11%2Bg501625f-py3-none-any.whl (186 kB)
Collecting packaging>=23.2 (from scikit-build-core)
  Downloading packaging-25.0-py3-none-any.whl.metadata (3.3 kB)
Collecting pathspec>=0.10.1 (from scikit-build-core)
  Downloading pathspec-0.12.1-py3-none-any.whl.metadata (21 kB)
Downloading packaging-25.0-py3-none-any.whl (66 kB)
Downloading pathspec-0.12.1-py3-none-any.whl (31 kB)
Installing collected packages: pathspec, packaging, scikit-build-core
Successfully installed packaging-25.0 pathspec-0.12.1 scikit-build-core-0.11.3.dev11+g501625f
$ python -m pip show scikit-build-core
Name: scikit_build_core
Version: 0.11.3.dev11+g501625f
Summary: Build backend for CMake based projects
Home-page: https://github.com/scikit-build/scikit-build-core
Author: 
Author-email: Henry Schreiner <[email protected]>
License: 
Location: /example/.pixi/envs/default/lib/python3.13/site-packages
Requires: packaging, pathspec
Required-by: 

@henryiii
Copy link

What about pybind11?

@matthewfeickert
Copy link
Member Author

matthewfeickert commented May 16, 2025

What about pybind11?

@henryiii That would be very welcome too! This is now Issue #134.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants